Fix next page token #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tdas can you review this PR? |
433cabf to
02c88af
Compare
Contributor
Author
|
@ramesh-db Thanks for the review! Do you have a code pointer for this repo's testing framework? |
Fokko
approved these changes
Jun 21, 2024
Collaborator
|
Hi @abrassel , you can checkout the file BaseTableCRUDTest and SdkTableCRUDTest. Ideally we would have wanted to add this check directly to the BaseTableCRUDTest, however we have currently kept the return type of |
Contributor
Author
|
Hi @ramesh-db I added a test. We should be good to go now. |
tdas
approved these changes
Jun 28, 2024
dennyglee
pushed a commit
that referenced
this pull request
Sep 2, 2024
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
tdas
pushed a commit
that referenced
this pull request
Sep 5, 2024
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 5, 2024
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (unitycatalog#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (unitycatalog#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (unitycatalog#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description of changes
Addresses #21
When performing a tables.list operation, it seems that the server returns the empty string "" instead of None as documented in the spec.
Fixed this by making the paginated request return
nullinstead.Testing
On a default run of unity catalog, did this manual test:
Any tips for testing this effectively?