Skip to content

Refactor Capable::vtable to return Option<NonNull<()>>#4252

Merged
laurmaedje merged 1 commit intotypst:mainfrom
bluebear94:mf/refactor-capable-trait
May 25, 2024
Merged

Refactor Capable::vtable to return Option<NonNull<()>>#4252
laurmaedje merged 1 commit intotypst:mainfrom
bluebear94:mf/refactor-capable-trait

Conversation

@bluebear94
Copy link
Copy Markdown
Contributor

This is slightly more efficient than returning the larger Option<*const ()>.

@laurmaedje laurmaedje added this pull request to the merge queue May 25, 2024
@laurmaedje
Copy link
Copy Markdown
Member

Nice!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 25, 2024
@laurmaedje
Copy link
Copy Markdown
Member

There were conflicts with your own PR #4240. Once they're resolved, we can proceed with the merge.

@bluebear94 bluebear94 force-pushed the mf/refactor-capable-trait branch from 55ba532 to b145f80 Compare May 25, 2024 17:32
@bluebear94
Copy link
Copy Markdown
Contributor Author

I fixed the conflicts.

@laurmaedje laurmaedje added this pull request to the merge queue May 25, 2024
Merged via the queue into typst:main with commit 1694327 May 25, 2024
Enter-tainer pushed a commit to Enter-tainer/typst that referenced this pull request May 26, 2024
PgBiel added a commit to tulio240/typst that referenced this pull request May 30, 2024
Refactor frame metadata into tags (typst#4212)


Require `Send` and `Sync` for worlds (typst#4219)


Optimize counters and state (typst#4223)


Add `windows` method to array (typst#4136)

Improve `CITATION.cff` file (typst#4201)


Fix equation resizing when adding the equation number (typst#4179)


`layout` documentation improvements (typst#4196)

Allow somewhat arbitrary characters as `mat`, `vec` and `cases` `delim` (typst#4211)


Do layout short-circuit in flow instead of realization (typst#4231)


Split `BitSet` into two types and make it a bit nicer (typst#4249)


Set default value of `raw.theme` to `auto`, and allow setting `raw.theme` to `auto` (typst#4186)


Extended cargo installation instructions (typst#4168)

Hint for language-region pair on `text.lang` (typst#4183)


Improve macro docs (+ Native*Data docs) (typst#4240)


Rephrase the sentence on variable scope in Scripting documentation (typst#4250)


Refactor `Capable::vtable` to return `Option<NonNull<()>>` (typst#4252)


Nicer test helper CSS (typst#4269)


Trim weak spacing at line start/end in paragraph layout (typst#4087)


Add ability to choose between minified and pretty-printed JSON (typst#4161)


Refactor PDF export (typst#4154)

Reorder syntax kinds (typst#4287)


Fix figure centering (typst#4276)

Fix `Default` impls for AST nodes (typst#4288)


Bump libc to v0.2.155 (typst#4268)


Bump time dependency (typst#4294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants