Merged
Conversation
Closed
PgBiel
added a commit
to tulio240/typst
that referenced
this pull request
May 30, 2024
Refactor frame metadata into tags (typst#4212) Require `Send` and `Sync` for worlds (typst#4219) Optimize counters and state (typst#4223) Add `windows` method to array (typst#4136) Improve `CITATION.cff` file (typst#4201) Fix equation resizing when adding the equation number (typst#4179) `layout` documentation improvements (typst#4196) Allow somewhat arbitrary characters as `mat`, `vec` and `cases` `delim` (typst#4211) Do layout short-circuit in flow instead of realization (typst#4231) Split `BitSet` into two types and make it a bit nicer (typst#4249) Set default value of `raw.theme` to `auto`, and allow setting `raw.theme` to `auto` (typst#4186) Extended cargo installation instructions (typst#4168) Hint for language-region pair on `text.lang` (typst#4183) Improve macro docs (+ Native*Data docs) (typst#4240) Rephrase the sentence on variable scope in Scripting documentation (typst#4250) Refactor `Capable::vtable` to return `Option<NonNull<()>>` (typst#4252) Nicer test helper CSS (typst#4269) Trim weak spacing at line start/end in paragraph layout (typst#4087) Add ability to choose between minified and pretty-printed JSON (typst#4161) Refactor PDF export (typst#4154) Reorder syntax kinds (typst#4287) Fix figure centering (typst#4276) Fix `Default` impls for AST nodes (typst#4288) Bump libc to v0.2.155 (typst#4268) Bump time dependency (typst#4294)
1 task
This was referenced Jun 4, 2024
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the
MetaElemwith a newTagElemthat fills a similar role, but works a bit differently. The purpose of both is to hold elements that will become available through introspection. However, theMetaElemdid this via the style chain, by attaching a style to the full subtree of content resulting from a locatable element, which resulted in lots of redundantFrameItem::Meta(Meta::Elem(_), ..)in the frames.The new
TagElemis generated exactly once per locatable element and holds the element directly. The challenge here is that the tag still needs to stick to the element so that if e.g. a heading moves to another page, the page number in the outline is still correct. To that extent, the flow layouter has gained a newpending_tagsarray and the tags are only flushed into the frames when something proper is layouted. Overall, the new mechanism is much more efficient. The old thing was actually so bad that the famous thesis benchmark improves by ~14% with this PR.The old
FrameItem::Metawas also used for hiding and links. These usages have been replaced by a completely internal mechanism for hiding and a new top-levelFrameItem::Linkfor links.This PR is only a first small step in an incremental refactor of realization and flow layout. The
TagElemandpending_tagsaren't necessarily the best way to implement tags in realization and layout, rather they are the least intrusive ones in the current setup. Things will change further as the refactoring progresses. The exact semantics of how tags will stick to elements are also still somewhat in-flux and will likely a change a bit in later refactor phases. These rules affect the results of.page()and.position()calls onlocations. With this PR, things should mostly be the same as on main, though there will be edge cases where things changed a bit. They might change again with further refactoring.