Set default value of raw.theme to auto, and allow setting raw.theme to auto#4186
Merged
laurmaedje merged 1 commit intotypst:mainfrom May 24, 2024
Merged
Set default value of raw.theme to auto, and allow setting raw.theme to auto#4186laurmaedje merged 1 commit intotypst:mainfrom
raw.theme to auto, and allow setting raw.theme to auto#4186laurmaedje merged 1 commit intotypst:mainfrom
Conversation
laurmaedje
reviewed
May 22, 2024
Member
laurmaedje
left a comment
There was a problem hiding this comment.
I think theme: none doesn't really make sense like this, since it's still a theme, just the default one. We should probably switch the default to auto instead.
We could also support theme: none to disable highlighting. Not sure whether we need that.
Contributor
Author
Agree.
Maybe, in this PR, we can switch to |
…eme` to `auto` NOTE: `raw.theme` is no longer allowed to be `none`
parse_theme when argument theme is noneraw.theme to auto, and allow setting raw.theme to auto
Member
|
Thanks! |
Enter-tainer
pushed a commit
to Enter-tainer/typst
that referenced
this pull request
May 26, 2024
PgBiel
added a commit
to tulio240/typst
that referenced
this pull request
May 30, 2024
Refactor frame metadata into tags (typst#4212) Require `Send` and `Sync` for worlds (typst#4219) Optimize counters and state (typst#4223) Add `windows` method to array (typst#4136) Improve `CITATION.cff` file (typst#4201) Fix equation resizing when adding the equation number (typst#4179) `layout` documentation improvements (typst#4196) Allow somewhat arbitrary characters as `mat`, `vec` and `cases` `delim` (typst#4211) Do layout short-circuit in flow instead of realization (typst#4231) Split `BitSet` into two types and make it a bit nicer (typst#4249) Set default value of `raw.theme` to `auto`, and allow setting `raw.theme` to `auto` (typst#4186) Extended cargo installation instructions (typst#4168) Hint for language-region pair on `text.lang` (typst#4183) Improve macro docs (+ Native*Data docs) (typst#4240) Rephrase the sentence on variable scope in Scripting documentation (typst#4250) Refactor `Capable::vtable` to return `Option<NonNull<()>>` (typst#4252) Nicer test helper CSS (typst#4269) Trim weak spacing at line start/end in paragraph layout (typst#4087) Add ability to choose between minified and pretty-printed JSON (typst#4161) Refactor PDF export (typst#4154) Reorder syntax kinds (typst#4287) Fix figure centering (typst#4276) Fix `Default` impls for AST nodes (typst#4288) Bump libc to v0.2.155 (typst#4268) Bump time dependency (typst#4294)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #4182 .
I found out the bug in
parse_theme. The functionparse_themealways wants to parse the argumentthemeintoEcoString, which raises error when meetingnone.As #4186 (review) , we set default value of
raw.themetoauto, and allow settingraw.themetoauto. To implement it, I redesigned the function signature (return value type):Err(...)indicates argumentthemefound but error met when casting it intoSmart<EcoString>;Ok((None, None))indicates argumentthemenot found;Ok((Some(Smart::Auto), None))indicates argumentthemefound, and it isauto;Ok((Some(Smart::Custom(path)), Some(data)))indicates argumentthemefound, and it isstr(path to the theme file).