PHPUnit 11#4269
Merged
Merged
Conversation
d5d2825 to
50e5270
Compare
derrabus
commented
Sep 3, 2024
| /doc/_build/vendor | ||
| /doc/_build/output | ||
| /composer.lock | ||
| /phpunit.phar |
Contributor
Author
There was a problem hiding this comment.
This will allow developer to place a PHAR distribution of PHPUnit in the main directory which is picked up and indexed by PHPStorm for code completion.
711396a to
d216c22
Compare
stof
reviewed
Sep 3, 2024
cae01e1 to
61eb1d2
Compare
cc10de6 to
6451425
Compare
fabpot
added a commit
that referenced
this pull request
Sep 4, 2024
…rabus) This PR was merged into the 4.x branch. Discussion ---------- Switch to static data provides for integration tests This change should make our integration test case compatible with PHPUnit 10 and 11. Merging the PR will hopefully give us a green build on #4269. 🤞🏻 Commits ------- 9282dbc Switch to static data provides for integration tests
03b003a to
be5913d
Compare
Contributor
Author
|
I don't understand the intl-extra failure. They look like they're failing because of data that could differ between ICU versions, but I'm not aware I have changed anything that could lead to different ICU data being loaded. Also, I get a different failure localy, but that one is at least consistent between 4.x and this branch. 😓 |
Contributor
Author
|
Apart from that, the test suite is green. 🎉 |
Member
|
Could it be that the |
7350aea to
f2053bb
Compare
Contributor
|
Thank you @derrabus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches our CI to PHPUnit 11.
TODO: