Fix MacroTest#4264
Merged
Merged
Conversation
Contributor
|
The failure looks related. |
Member
|
The failure is because the compiled code is different depending on the state of |
95c642a to
1e5dea4
Compare
Contributor
Author
|
Indeed. I'm now testing both variants and set that parameter explicitly. |
Contributor
|
Thank you @derrabus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of a typo in a variable name,
MacroTestwas never executed. This PR fixes the typo and adjusts the expected compiled PHP code, assuming that the current behavior is correct.