Remove obsolete "requires PHP" annotation#4268
Merged
Merged
Conversation
xabbuh
approved these changes
Sep 3, 2024
Contributor
|
As the work has already been done in 4.x, I don't want us to do it again in 3.x now that we've bumped the min PHP version to 8.0. |
Contributor
Author
|
This PR removes two annotations. One of them is still present on 4.x, while the other one is gone. So my change actually contains one line removal "done again" on 3.x. Well… 😓 Shall I rebase the PR onto 4.x? |
0c1c565 to
fe2803d
Compare
Contributor
Author
|
Rebased. 🙂 |
Contributor
|
Thank you @derrabus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.