Open
Conversation
jfly
added a commit
to jfly/tree-sitter-embedded-template
that referenced
this pull request
Feb 9, 2026
`name` is not allowed to contain `-`'s, see https://github.com/tree-sitter/tree-sitter/blob/v0.26.5/docs/src/assets/schemas/config.schema.json#L13-L17. Alternatively, would it be better to relax the regex upstream? This isn't the only repo with this issue, see <tree-sitter/tree-sitter-ql-dbscheme#7>.
`name` is not allowed to contain `-`'s, see <https://github.com/tree-sitter/tree-sitter/blob/v0.26.5/docs/src/assets/schemas/config.schema.json#L13-L17>. Alternatively, would it be better to relax the regex upstream?
jfly
added a commit
to jfly/tree-sitter-embedded-template
that referenced
this pull request
Feb 9, 2026
`name` is not allowed to contain `-`'s, see https://github.com/tree-sitter/tree-sitter/blob/v0.26.5/docs/src/assets/schemas/config.schema.json#L13-L17. Alternatively, would it be better to relax the regex upstream? This isn't the only repo with this issue, see <tree-sitter/tree-sitter-ql-dbscheme#7>.
jfly
added a commit
to jfly/tree-sitter-c-sharp
that referenced
this pull request
Feb 9, 2026
`name` is not allowed to contain `-`'s, see <https://github.com/tree-sitter/tree-sitter/blob/v0.26.5/docs/src/assets/schemas/config.schema.json#L13-L17>. Alternatively, would it be better to relax the regex upstream? This is not the only repo with this issue, see <tree-sitter/tree-sitter-ql-dbscheme#7>.
jfly
added a commit
to jfly/tree-sitter-janet-simple
that referenced
this pull request
Feb 9, 2026
`name` is not allowed to contain `-`'s, see <https://github.com/tree-sitter/tree-sitter/blob/v0.26.5/docs/src/assets/schemas/config.schema.json#L13-L17>. Alternatively, would it be better to relax the regex upstream? This is not the only repo with this issue, see <tree-sitter/tree-sitter-ql-dbscheme#7>.
This was referenced Feb 9, 2026
jfly
added a commit
to jfly/tree-sitter
that referenced
this pull request
Feb 9, 2026
A number of grammars in the wild have this character in their name: - sogaiu/tree-sitter-janet-simple#7 - tree-sitter/tree-sitter-c-sharp#408 - tree-sitter/tree-sitter-embedded-template#45 - tree-sitter/tree-sitter-ql-dbscheme#7 I read through tree-sitter#3700 and tree-sitter#3637, and it doesn't look like there was much discussion about this name regex, so hopefully this is an acceptable change?
Author
|
Asked upstream: tree-sitter/tree-sitter#5315 |
WillLillis
pushed a commit
to tree-sitter/tree-sitter
that referenced
this pull request
Feb 10, 2026
A number of grammars in the wild have this character in their name: - sogaiu/tree-sitter-janet-simple#7 - tree-sitter/tree-sitter-c-sharp#408 - tree-sitter/tree-sitter-embedded-template#45 - tree-sitter/tree-sitter-ql-dbscheme#7 I read through #3700 and #3637, and it doesn't look like there was much discussion about this name regex, so hopefully this is an acceptable change?
github-actions bot
pushed a commit
to tree-sitter/tree-sitter
that referenced
this pull request
Feb 10, 2026
A number of grammars in the wild have this character in their name: - sogaiu/tree-sitter-janet-simple#7 - tree-sitter/tree-sitter-c-sharp#408 - tree-sitter/tree-sitter-embedded-template#45 - tree-sitter/tree-sitter-ql-dbscheme#7 I read through #3700 and #3637, and it doesn't look like there was much discussion about this name regex, so hopefully this is an acceptable change? (cherry picked from commit 7d3c321)
WillLillis
pushed a commit
to tree-sitter/tree-sitter
that referenced
this pull request
Feb 10, 2026
A number of grammars in the wild have this character in their name: - sogaiu/tree-sitter-janet-simple#7 - tree-sitter/tree-sitter-c-sharp#408 - tree-sitter/tree-sitter-embedded-template#45 - tree-sitter/tree-sitter-ql-dbscheme#7 I read through #3700 and #3637, and it doesn't look like there was much discussion about this name regex, so hopefully this is an acceptable change? (cherry picked from commit 7d3c321)
Author
|
Update: |
jfly
added a commit
to jfly/tree-sitter-janet-simple
that referenced
this pull request
Feb 10, 2026
`name` is not allowed to contain `-`'s, see <https://github.com/tree-sitter/tree-sitter/blob/v0.26.5/docs/src/assets/schemas/config.schema.json#L13-L17>. Alternatively, would it be better to relax the regex upstream? This is not the only repo with this issue, see <tree-sitter/tree-sitter-ql-dbscheme#7>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nameis not allowed to contain-'s, seehttps://github.com/tree-sitter/tree-sitter/blob/v0.26.5/docs/src/assets/schemas/config.schema.json#L13-L17.
Alternatively, would it be better to relax the regex upstream?