feat: allow - in grammar names#5315
Merged
WillLillis merged 1 commit intotree-sitter:masterfrom Feb 10, 2026
Merged
Conversation
A number of grammars in the wild have this character in their name: - sogaiu/tree-sitter-janet-simple#7 - tree-sitter/tree-sitter-c-sharp#408 - tree-sitter/tree-sitter-embedded-template#45 - tree-sitter/tree-sitter-ql-dbscheme#7 I read through tree-sitter#3700 and tree-sitter#3637, and it doesn't look like there was much discussion about this name regex, so hopefully this is an acceptable change?
This was referenced Feb 9, 2026
WillLillis
approved these changes
Feb 10, 2026
Member
|
Thanks! |
|
Successfully created backport PR for |
Collaborator
|
Please have a look at this discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of grammars in the wild have this character in their name:
tree-sitter.jsonnow obeys upstream schema sogaiu/tree-sitter-janet-simple#7tree-sitter.jsontree-sitter-c-sharp#408tree-sitter.jsontree-sitter-embedded-template#45grammars.0.nametree-sitter-ql-dbscheme#7I read through #3700 and #3637, and it doesn't look like there was much discussion about this name regex, so hopefully this is an acceptable change?