Skip to content

chore: add schema link to tree-sitter.json#45

Open
jfly wants to merge 1 commit intotree-sitter:masterfrom
jfly:fix-tree-sitter-json
Open

chore: add schema link to tree-sitter.json#45
jfly wants to merge 1 commit intotree-sitter:masterfrom
jfly:fix-tree-sitter-json

Conversation

@jfly
Copy link

@jfly jfly commented Feb 9, 2026

No description provided.

@jfly jfly force-pushed the fix-tree-sitter-json branch from aab9c36 to a7f0993 Compare February 9, 2026 06:03
jfly added a commit to jfly/tree-sitter that referenced this pull request Feb 9, 2026
A number of grammars in the wild have this character in their name:

- sogaiu/tree-sitter-janet-simple#7
- tree-sitter/tree-sitter-c-sharp#408
- tree-sitter/tree-sitter-embedded-template#45
- tree-sitter/tree-sitter-ql-dbscheme#7

I read through tree-sitter#3700 and
tree-sitter#3637, and it doesn't
look like there was much discussion about this name regex, so hopefully
this is an acceptable change?
@jfly
Copy link
Author

jfly commented Feb 9, 2026

Asked upstream: tree-sitter/tree-sitter#5315

WillLillis pushed a commit to tree-sitter/tree-sitter that referenced this pull request Feb 10, 2026
A number of grammars in the wild have this character in their name:

- sogaiu/tree-sitter-janet-simple#7
- tree-sitter/tree-sitter-c-sharp#408
- tree-sitter/tree-sitter-embedded-template#45
- tree-sitter/tree-sitter-ql-dbscheme#7

I read through #3700 and
#3637, and it doesn't
look like there was much discussion about this name regex, so hopefully
this is an acceptable change?
github-actions bot pushed a commit to tree-sitter/tree-sitter that referenced this pull request Feb 10, 2026
A number of grammars in the wild have this character in their name:

- sogaiu/tree-sitter-janet-simple#7
- tree-sitter/tree-sitter-c-sharp#408
- tree-sitter/tree-sitter-embedded-template#45
- tree-sitter/tree-sitter-ql-dbscheme#7

I read through #3700 and
#3637, and it doesn't
look like there was much discussion about this name regex, so hopefully
this is an acceptable change?

(cherry picked from commit 7d3c321)
WillLillis pushed a commit to tree-sitter/tree-sitter that referenced this pull request Feb 10, 2026
A number of grammars in the wild have this character in their name:

- sogaiu/tree-sitter-janet-simple#7
- tree-sitter/tree-sitter-c-sharp#408
- tree-sitter/tree-sitter-embedded-template#45
- tree-sitter/tree-sitter-ql-dbscheme#7

I read through #3700 and
#3637, and it doesn't
look like there was much discussion about this name regex, so hopefully
this is an acceptable change?

(cherry picked from commit 7d3c321)
@jfly jfly force-pushed the fix-tree-sitter-json branch from a7f0993 to d204abe Compare February 10, 2026 03:16
@jfly jfly changed the title fix: invalid values for grammars.*.name chore: add schema link to tree-sitter.json Feb 10, 2026
@jfly
Copy link
Author

jfly commented Feb 10, 2026

Upstream now allows for - characters in name, so this PR just adds the schema link so other tooling understands the rules of this file.

Edit: actually, - is discouraged. See discussion here: tree-sitter/tree-sitter#5321. Please advise what you'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant