config: adjust default value of config rocksdb.max-manifest-file-size from 128MiB to 256MiB#18496
Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom Aug 28, 2025
Merged
Conversation
Signed-off-by: glorv <glorvs@163.com>
hbisheng
approved these changes
Jun 3, 2025
Contributor
[LGTM Timeline notifier]Timeline:
|
LykxSassinator
approved these changes
Jun 8, 2025
Contributor
LykxSassinator
left a comment
There was a problem hiding this comment.
Remember to create a corresponding PR for docs-cn to document this change.
Contributor
Author
|
/retest |
Contributor
Author
|
@zhangjinpeng87 PTAL, thanks |
Signed-off-by: glorv <glorvs@163.com>
rocksdb.max-manifest-file-size from 128MiB to 512MiBrocksdb.max-manifest-file-size from 128MiB to 256MiB
Contributor
Author
|
@zhangjinpeng87 PTAL thanks |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, hbisheng, LykxSassinator, zhangjinpeng87 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
14 tasks
yibin87
pushed a commit
to yibin87/tikv
that referenced
this pull request
Sep 2, 2025
…e` from 128MiB to 256MiB (tikv#18496) ref tikv#15990 The default value of config `rocksdb.max-manifest-file-size` is too small for large clusters with more than 100k sst files. It can cause long ingest latency when the effective manifest file size exceed the threshold. So this PR adjust the default value to 256MiB which should be a large enough value. Signed-off-by: glorv <glorvs@163.com>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
…e` from 128MiB to 256MiB (#18496) (#18889) close #18996 The default value of config `rocksdb.max-manifest-file-size` is too small for large clusters with more than 100k sst files. It can cause long ingest latency when the effective manifest file size exceed the threshold. So this PR adjust the default value to 256MiB which should be a large enough value. Signed-off-by: glorv <glorvs@163.com> Co-authored-by: glorv <glorvs@163.com>
3AceShowHand
pushed a commit
to 3AceShowHand/tikv
that referenced
this pull request
Oct 13, 2025
…e` from 128MiB to 256MiB (tikv#18496) ref tikv#15990 The default value of config `rocksdb.max-manifest-file-size` is too small for large clusters with more than 100k sst files. It can cause long ingest latency when the effective manifest file size exceed the threshold. So this PR adjust the default value to 256MiB which should be a large enough value. Signed-off-by: glorv <glorvs@163.com> Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: close #18996
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note