Skip to content

config: adjust default value of config rocksdb.max-manifest-file-size from 128MiB to 256MiB (#18496)#18887

Open
ti-chi-bot wants to merge 3 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-18496-to-release-7.5
Open

config: adjust default value of config rocksdb.max-manifest-file-size from 128MiB to 256MiB (#18496)#18887
ti-chi-bot wants to merge 3 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-18496-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 28, 2025 •
edited by glorv
Loading

This is an automated cherry-pick of #18496

What is changed and how it works?

Issue Number: close #18996

What's Changed:

The default value of config `rocksdb.max-manifest-file-size` is too small for large clusters with more than 100k sst files. It can cause long ingest latency when the effective manifest file size exceed the threshold. So this PR adjust the default value to 256MiB which should be a large enough value.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

glorv added 3 commits August 28, 2025 18:18
@glorv @ti-chi-bot
adjust default value of config from 128MiB to 512MiB
ad278b4 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
Update mod.rs
ed83686 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
fix test
1057baa 
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Aug 28, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 28, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Connor1996
Connor1996 approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 29, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Connor1996, overvenus
Once this PR has been reviewed and has the lgtm label, please assign zhangjinpeng87 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-29 20:54:29.979460468 +0000 UTC m=+559961.857291422: ☑️ agreed by Connor1996.
  • 2025-09-05 09:52:21.509995284 +0000 UTC m=+9408.069876781: ☑️ agreed by overvenus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

Assignees

@glorv glorv

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @overvenus @Connor1996 @glorv