Skip to content

config: adjust default value of config rocksdb.max-manifest-file-size from 128MiB to 256MiB (#18496)#18889

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18496-to-release-8.5
Sep 24, 2025
Merged

config: adjust default value of config rocksdb.max-manifest-file-size from 128MiB to 256MiB (#18496)#18889
ti-chi-bot[bot] merged 4 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18496-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 28, 2025 •
edited by glorv
Loading

This is an automated cherry-pick of #18496

What is changed and how it works?

Issue Number: close #18996

What's Changed:

The default value of config `rocksdb.max-manifest-file-size` is too small for large clusters with more than 100k sst files. It can cause long ingest latency when the effective manifest file size exceed the threshold. So this PR adjust the default value to 256MiB which should be a large enough value.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

glorv added 3 commits August 28, 2025 18:19
@glorv @ti-chi-bot
adjust default value of config from 128MiB to 512MiB
fd4ca30 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
Update mod.rs
c4f8f36 
Signed-off-by: glorv <glorvs@163.com>
@glorv @ti-chi-bot
fix test
194ddd1 
Signed-off-by: glorv <glorvs@163.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Aug 28, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 28, 2025
Merged
9 tasks
@glorv
Copy link
Contributor

glorv commented Aug 29, 2025

/retest

1 similar comment
@glorv
Copy link
Contributor

glorv commented Aug 29, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 29, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-29 04:09:34.590506444 +0000 UTC m=+499666.468337388: ☑️ agreed by glorv.
  • 2025-09-23 06:26:46.203898149 +0000 UTC m=+338016.274391828: ☑️ agreed by overvenus.

@glorv
Copy link
Contributor

glorv commented Sep 23, 2025

/retest

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 23, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, glorv, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit 46d7215 into tikv:release-8.5 Sep 24, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-18496-to-release-8.5 branch September 24, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@glorv glorv glorv approved these changes

Assignees

@glorv glorv

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @glorv @overvenus @cfzjywxk