Skip to content

backup_stream: encode ts related field into meta file path#18482

Merged
ti-chi-bot[bot] merged 7 commits intotikv:masterfrom
3pointer:new_format_backupmeta
Jun 3, 2025
Merged

backup_stream: encode ts related field into meta file path#18482
ti-chi-bot[bot] merged 7 commits intotikv:masterfrom
3pointer:new_format_backupmeta

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented May 27, 2025

What is changed and how it works?

Issue Number: close #18497
ref pingcap/tidb#61318

What's Changed:

backup_stream: encode ts related field into meta file path.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Before this PR
image

After
image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2025
Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2025
Signed-off-by: 3pointer <luancheng@pingcap.com>
@3pointer 3pointer marked this pull request as ready for review May 30, 2025 10:02
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2025
Signed-off-by: 3pointer <luancheng@pingcap.com>
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

3pointer and others added 3 commits June 3, 2025 11:49
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Signed-off-by: 3pointer <qdlc2010@gmail.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 3, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 3, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 3, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-03 06:18:57.054284237 +0000 UTC m=+336223.256629502: ☑️ agreed by YuJuncen.
  • 2025-06-03 07:37:42.855061598 +0000 UTC m=+340949.057406863: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-linked-issue labels Jun 3, 2025
@ti-chi-bot ti-chi-bot bot merged commit a0777c2 into tikv:master Jun 3, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jun 3, 2025
exit-code-1 pushed a commit to exit-code-1/tikv that referenced this pull request Jun 4, 2025
close tikv#18434

The real bug has been fixed by distinguishing Titan blob index from RocksDB blob index during RocksDB upgrade effort.
This PR just adds a regression test to prove it is fixed.
We reproduced the error with the same test code in 7.5

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

downgrade log level form error to warning

downgrade log level from error to warning

backup_stream: encode ts related field into meta file path (tikv#18482)

close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <qdlc2010@gmail.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
exit-code-1 pushed a commit to exit-code-1/tikv that referenced this pull request Jun 5, 2025
close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <qdlc2010@gmail.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
exit-code-1 pushed a commit to exit-code-1/tikv that referenced this pull request Jun 5, 2025
close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <qdlc2010@gmail.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>

pd: degrade useless log (tikv#18504)

close tikv#18506

Signed-off-by: bufferflies <1045931706@qq.com>

tikv:downgrade log level from error to warning

Titan: Add a regression test for Titan disabling (tikv#18477)

close tikv#18434

The real bug has been fixed by distinguishing Titan blob index from RocksDB blob index during RocksDB upgrade effort.
This PR just adds a regression test to prove it is fixed.
We reproduced the error with the same test code in 7.5

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

backup_stream: encode ts related field into meta file path (tikv#18482)

close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <qdlc2010@gmail.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>

pd: degrade useless log (tikv#18504)

close tikv#18506

Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 1, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18607.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 1, 2025
close tikv#18497, ref pingcap/tidb#61318

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 10, 2025
…18607)

close #18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
RidRisR pushed a commit to RidRisR/tikv that referenced this pull request Oct 9, 2025
… (tikv#18607)

close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
RidRisR pushed a commit to RidRisR/tikv that referenced this pull request Oct 9, 2025
… (tikv#18607)

close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2025
…19033)

close #18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: 3pointer <luancheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log Backup: support filter meta file by name

4 participants