Skip to content

pd: degrade useless log#18504

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
bufferflies:degrade_log
Jun 5, 2025
Merged

pd: degrade useless log#18504
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
bufferflies:degrade_log

Conversation

@bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Jun 4, 2025 •
edited
Loading

What is changed and how it works?

Issue Number: Close #18506

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@bufferflies
degrade useless log
c9a7249 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 4, 2025
@bufferflies bufferflies marked this pull request as ready for review June 4, 2025 09:35
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2025
@bufferflies bufferflies added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jun 4, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2025

@exit-code-1: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2025
@bufferflies
Copy link
Contributor Author

bufferflies commented Jun 4, 2025

/test pull-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exit-code-1, lhy1024, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-04 10:03:37.602611643 +0000 UTC m=+436103.804956903: ☑️ agreed by lhy1024.
  • 2025-06-05 02:05:53.725337236 +0000 UTC m=+493839.927682502: ☑️ agreed by LykxSassinator.

@ti-chi-bot ti-chi-bot bot merged commit 46b7ac8 into tikv:master Jun 5, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jun 5, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 5, 2025

In response to a cherrypick label: new pull request created to branch release-7.1: #18507.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2025
Open
9 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 5, 2025

In response to a cherrypick label: new pull request created to branch release-7.5: #18508.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2025
Open
9 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 5, 2025

In response to a cherrypick label: new pull request created to branch release-8.1: #18509.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2025
Open
9 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 5, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18510.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2025
Open
9 tasks
exit-code-1 added a commit to exit-code-1/tikv that referenced this pull request Jun 5, 2025
@exit-code-1
pd: degrade useless log (tikv#18504)
52536d5 
close tikv#18506

Signed-off-by: bufferflies <1045931706@qq.com>
exit-code-1 pushed a commit to exit-code-1/tikv that referenced this pull request Jun 5, 2025
@3pointer @exit-code-1
backup_stream: encode ts related field into meta file path (tikv#18482)
e293723 
close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <qdlc2010@gmail.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>

pd: degrade useless log (tikv#18504)

close tikv#18506

Signed-off-by: bufferflies <1045931706@qq.com>

tikv:downgrade log level from error to warning

Titan: Add a regression test for Titan disabling (tikv#18477)

close tikv#18434

The real bug has been fixed by distinguishing Titan blob index from RocksDB blob index during RocksDB upgrade effort.
This PR just adds a regression test to prove it is fixed.
We reproduced the error with the same test code in 7.5

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

backup_stream: encode ts related field into meta file path (tikv#18482)

close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: 3pointer <qdlc2010@gmail.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>

pd: degrade useless log (tikv#18504)

close tikv#18506

Signed-off-by: bufferflies <1045931706@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

+2 more reviewers

@lhy1024 lhy1024 lhy1024 approved these changes

@exit-code-1 exit-code-1 exit-code-1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

log: degrade some error log

5 participants

@bufferflies @ti-chi-bot @LykxSassinator @lhy1024 @exit-code-1