Skip to content

backup_stream: encode ts related field into meta file path (#18482) #19033

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5-20250122-v8.5.0from
RidRisR:cp#18482
Oct 10, 2025
Merged

backup_stream: encode ts related field into meta file path (#18482) #19033
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5-20250122-v8.5.0from
RidRisR:cp#18482

Conversation

@RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Oct 9, 2025 •
edited
Loading

What is changed and how it works?

close #18497, ref pingcap/tidb#61318

What's Changed:

backup_stream: encode ts related field into meta file path.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 9, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 9, 2025

Hi @RidRisR. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot @3pointer @RidRisR
backup_stream: encode ts related field into meta file path (tikv#18482)…
4bcdcfb 
… (tikv#18607)

close tikv#18497, ref pingcap/tidb#61318

backup_stream: encode ts related field into meta file path.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 9, 2025
@YuJuncen
Copy link
Contributor

YuJuncen commented Oct 9, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 9, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 10, 2025
@RidRisR RidRisR changed the title backup_stream: encode ts related field into meta file path (#18482) (… backup_stream: encode ts related field into meta file path (#18482) Oct 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-10 02:53:12.692299667 +0000 UTC m=+408781.723399005: ☑️ agreed by YuJuncen.
  • 2025-10-10 05:44:35.814083735 +0000 UTC m=+419064.845183053: ☑️ agreed by Leavrth.

@ti-chi-bot ti-chi-bot bot merged commit eb0ff1d into tikv:release-8.5-20250122-v8.5.0 Oct 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RidRisR @YuJuncen @Leavrth @ti-chi-bot