raftstore: enhance the detection to cover I/O jitters on kvdb.#18439
Merged
ti-chi-bot[bot] merged 6 commits intotikv:masterfrom May 22, 2025
Merged
raftstore: enhance the detection to cover I/O jitters on kvdb.#18439ti-chi-bot[bot] merged 6 commits intotikv:masterfrom
ti-chi-bot[bot] merged 6 commits intotikv:masterfrom
Conversation
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Contributor
|
Skipping CI for Draft Pull Request. |
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Contributor
Author
|
/retest |
hbisheng
approved these changes
May 20, 2025
Member
hbisheng
left a comment
There was a problem hiding this comment.
LGTM. Looks like the PR is mainly about tuning the params:
- inspect_kvdb_interval: 2s -> 100ms
- ratio_thresh：60% -> 10%
These changes will significantly increase the sensitivity of the KV IO jitter detection. This makes sense if we want to catch jitter as short as 100ms, though the trade-off is a higher risk of false positives.
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
hbisheng
reviewed
May 21, 2025
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
overvenus
approved these changes
May 22, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbisheng, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
This was referenced Jul 18, 2025
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Jul 18, 2025
close tikv#18463 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
okJiang
pushed a commit
to okJiang/tikv
that referenced
this pull request
Oct 13, 2025
…18439) close tikv#18463 Enhances the detection mechanism to cover the I/O jitters on kvdb disk if deploys with separated mount paths. Signed-off-by: lucasliang <nkcs_lykx@hotmail.com> Signed-off-by: okjiang <819421878@qq.com>
okJiang
pushed a commit
to okJiang/tikv
that referenced
this pull request
Oct 27, 2025
…18439) (tikv#18723) close tikv#18463 Enhances the detection mechanism to cover the I/O jitters on kvdb disk if deploys with separated mount paths. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: lucasliang <nkcs_lykx@hotmail.com> Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
okJiang
pushed a commit
to okJiang/tikv
that referenced
this pull request
Oct 28, 2025
…18439) (tikv#18723) close tikv#18463 Enhances the detection mechanism to cover the I/O jitters on kvdb disk if deploys with separated mount paths. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: lucasliang <nkcs_lykx@hotmail.com> Co-authored-by: lucasliang <nkcs_lykx@hotmail.com> Signed-off-by: okjiang <819421878@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #18463
What's Changed:
In previous work #17801, TiKV has introduced the detection mechanism for kvdb disk to detect I/O hang issues.
However, recent customer feedback highlighted the need to extend detection coverage to I/O jitters, ensuring TiKV can automatically recover from abnormal states caused by KVDB I/O jitters.
Therefore, this ticket is built to tracks the development efforts to enhance TiKV’s I/O jitter detection and recovery mechanism. And the majority parts of this change are listed as followings show:
raftstore.inspect_kvdb_interval: 2s -> 100msSlowScore::ratio_thresh：60% -> 10%Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note