Skip to content

raftstore: enhance the detection to cover I/O jitters on kvdb. (#18439)#18481

Merged
ti-chi-bot[bot] merged 6 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18439-to-release-8.5
Jul 9, 2025
Merged

raftstore: enhance the detection to cover I/O jitters on kvdb. (#18439)#18481
ti-chi-bot[bot] merged 6 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18439-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #18439

What is changed and how it works?

Issue Number: Close #18463

What's Changed:

In previous work #17801, TiKV has introduced the detection mechanism for kvdb disk to detect I/O hang issues.

However, recent customer feedback highlighted the need to extend detection coverage to I/O jitters, ensuring TiKV can automatically recover from abnormal states caused by KVDB I/O jitters.

Therefore, this ticket is built to tracks the development efforts to enhance TiKV’s I/O jitter detection and recovery mechanism. And the majority parts of this change are listed as followings show:

  • for configurations:
    • raftstore.inspect_kvdb_interval: 2s -> 100ms
  • for detection mechanism on kvdb:
    • SlowScore::ratio_thresh:60% -> 10%
Enhances the detection mechanism to cover the I/O jitters on kvdb disk if deploys with separated mount paths.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Workloads v8.5.1 With this PR
Special workloads image image
tpcc 1k warehouses image image
Sysbench - oltp_read_write image image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Enhances the detection mechanism to cover the I/O jitters on kvdb disk if deploys with separated mount paths.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels May 27, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 27, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 27, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-27 07:05:21.991270935 +0000 UTC m=+339052.363058397: ☑️ agreed by LykxSassinator.
  • 2025-05-27 08:49:49.749849569 +0000 UTC m=+345320.121637032: ☑️ agreed by hbisheng.

Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, LykxSassinator, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LykxSassinator,zhangjinpeng87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 9, 2025
@ti-chi-bot ti-chi-bot bot merged commit 9ec9313 into tikv:release-8.5 Jul 9, 2025
4 checks passed
@LykxSassinator LykxSassinator added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 18, 2025
ti-chi-bot added a commit to ti-chi-bot/tikv that referenced this pull request Jul 18, 2025
close tikv#18463

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created to branch release-7.5: #18720.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member Author

In response to a cherrypick label: new pull request created to branch release-8.1: #18721.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants