Skip to content

raftstore: enhance the detection to cover I/O jitters on kvdb. (#18439)#18722

Open
ti-chi-bot wants to merge 6 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-18439-to-release-8.1
Open

raftstore: enhance the detection to cover I/O jitters on kvdb. (#18439)#18722
ti-chi-bot wants to merge 6 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-18439-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #18439

What is changed and how it works?

Issue Number: Close #18463

What's Changed:

In previous work #17801, TiKV has introduced the detection mechanism for kvdb disk to detect I/O hang issues.

However, recent customer feedback highlighted the need to extend detection coverage to I/O jitters, ensuring TiKV can automatically recover from abnormal states caused by KVDB I/O jitters.

Therefore, this ticket is built to tracks the development efforts to enhance TiKV’s I/O jitter detection and recovery mechanism. And the majority parts of this change are listed as followings show:

  • for configurations:
    • raftstore.inspect_kvdb_interval: 2s -> 100ms
  • for detection mechanism on kvdb:
    • SlowScore::ratio_thresh:60% -> 10%
Enhances the detection mechanism to cover the I/O jitters on kvdb disk if deploys with separated mount paths.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Workloads v8.5.1 With this PR
Special workloads image image
tpcc 1k warehouses image image
Sysbench - oltp_read_write image image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Enhances the detection mechanism to cover the I/O jitters on kvdb disk if deploys with separated mount paths.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 18, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-18 09:03:23.058091142 +0000 UTC m=+121.463364983: ☑️ agreed by LykxSassinator.
  • 2025-07-18 09:03:45.107582612 +0000 UTC m=+143.512856440: ☑️ agreed by hbisheng.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 16, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-check-deps 3967d62 link true /test pull-check-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants