Skip to content

upload pause state before unloading a task#18131

Merged
ti-chi-bot[bot] merged 5 commits intotikv:masterfrom
YuJuncen:fix-fatal-reporting
Jan 24, 2025
Merged

upload pause state before unloading a task#18131
ti-chi-bot[bot] merged 5 commits intotikv:masterfrom
YuJuncen:fix-fatal-reporting

Conversation

@YuJuncen
Copy link
Contributor

What is changed and how it works?

Issue Number: Close #18087

What's Changed:

This PR makes a task only be unloaded after it reports the state to PD.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that may cause PiTR stop to advance after a PD failure.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 16, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 16, 2025
@YuJuncen
Copy link
Contributor Author

/test pull-unit-test

Signed-off-by: hillium <yu745514916@live.com>
@YuJuncen YuJuncen force-pushed the fix-fatal-reporting branch from a0e42f3 to 151a320 Compare January 21, 2025 02:52
Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: hillium <yu745514916@live.com>
@YuJuncen YuJuncen force-pushed the fix-fatal-reporting branch from 805e0b0 to efd179a Compare January 22, 2025 04:44
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-16 10:05:46.062342901 +0000 UTC m=+199417.517389043: ☑️ agreed by Leavrth.
  • 2025-01-22 09:09:41.61893684 +0000 UTC m=+258308.949856244: ☑️ agreed by 3pointer.

@3pointer
Copy link
Contributor

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, iosmanthus, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2025
@ti-chi-bot ti-chi-bot bot merged commit fcf4b96 into tikv:master Jan 24, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jan 24, 2025
@YuJuncen YuJuncen added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 5, 2025
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Feb 5, 2025

/run-cherry-picker

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Feb 5, 2025
close tikv#18087

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #18183.

ti-chi-bot bot added a commit that referenced this pull request Feb 11, 2025
close #18087

This PR makes a task only be unloaded after it reports the state to PD.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hillium <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: hillium <yujuncen@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 19, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18230.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Feb 19, 2025
close tikv#18087

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
YuJuncen added a commit to ti-chi-bot/tikv that referenced this pull request Feb 26, 2025
close tikv#18087

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hillium <yu745514916@live.com>
ti-chi-bot bot added a commit that referenced this pull request Feb 27, 2025
close #18087

This PR makes a task only be unloaded after it reports the state to PD.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: hillium <yu745514916@live.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: hillium <yu745514916@live.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@Leavrth Leavrth added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Apr 10, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18376.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Apr 10, 2025
close tikv#18087

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #18377.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18378.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Apr 10, 2025
close tikv#18087

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2025
close #18087

This PR makes a task only be unloaded after it reports the state to PD.

Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>

Co-authored-by: hillium <yu745514916@live.com>
Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
RidRisR pushed a commit to RidRisR/tikv that referenced this pull request Sep 28, 2025
close tikv#18087

This PR makes a task only be unloaded after it reports the state to PD.

Signed-off-by: hillium <yu745514916@live.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
RidRisR pushed a commit to RidRisR/tikv that referenced this pull request Sep 28, 2025
close tikv#18087

This PR makes a task only be unloaded after it reports the state to PD.

Signed-off-by: hillium <yu745514916@live.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this pull request Oct 9, 2025
close #18087

Signed-off-by: hillium <yu745514916@live.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

log backup status is normal and lag more and more after injection pd leader io delay 500ms last for 10mins and then recover

6 participants