Skip to content

upload pause state before unloading a task (#18131)#19009

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5-20250122-v8.5.0from
RidRisR:cp#18131
Oct 9, 2025
Merged

upload pause state before unloading a task (#18131)#19009
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5-20250122-v8.5.0from
RidRisR:cp#18131

Conversation

@RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Sep 28, 2025 •
edited
Loading

close #18087

This PR makes a task only be unloaded after it reports the state to PD.

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. labels Sep 28, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2025

Hi @RidRisR. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2025
@YuJuncen @ti-chi-bot @RidRisR
upload pause state before unloading a task (tikv#18131)
24a0f3f 
close tikv#18087

This PR makes a task only be unloaded after it reports the state to PD.

Signed-off-by: hillium <yu745514916@live.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 30, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 30, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-30 05:07:36.462889855 +0000 UTC m=+147636.719621256: ☑️ agreed by YuJuncen.
  • 2025-09-30 09:39:51.810702946 +0000 UTC m=+163972.067434356: ☑️ agreed by Leavrth.

@RidRisR
fix ci
055c1b1 
Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 9, 2025
@YuJuncen
Copy link
Contributor

YuJuncen commented Oct 9, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 9, 2025
@ti-chi-bot ti-chi-bot bot merged commit 0140bb6 into tikv:release-8.5-20250122-v8.5.0 Oct 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RidRisR @YuJuncen @Leavrth