Skip to content

upload pause state before unloading a task (#18131)#18376

Merged
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18131-to-release-8.5
Apr 16, 2025
Merged

upload pause state before unloading a task (#18131)#18376
ti-chi-bot[bot] merged 5 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18131-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 10, 2025

This is an automated cherry-pick of #18131

What is changed and how it works?

Issue Number: Close #18087

What's Changed:

This PR makes a task only be unloaded after it reports the state to PD.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that may cause PiTR stop to advance after a PD failure.

YuJuncen added 3 commits April 10, 2025 07:32
@YuJuncen @ti-chi-bot
upload pause state before unloading a task
48feaaf 
Signed-off-by: hillium <yu745514916@live.com>
@YuJuncen @ti-chi-bot
fix build
3f89271 
Signed-off-by: hillium <yu745514916@live.com>
@YuJuncen @ti-chi-bot
added error log
1a63fc0 
Signed-off-by: hillium <yu745514916@live.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Apr 10, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 10, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 10, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 10, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-10 07:34:48.921066527 +0000 UTC m=+2328182.605302623: ☑️ agreed by Leavrth.
  • 2025-04-10 07:57:12.368885061 +0000 UTC m=+2329526.053121156: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 10, 2025
@YuJuncen
Copy link
Contributor

YuJuncen commented Apr 11, 2025 


error[vulnerability]: Use-After-Free in `Md::fetch` and `Cipher::fetch`

    ┌─ /home/jenkins/tikv-src/Cargo.lock:351:1

    │

351 │ openssl 0.10.57 registry+https://github.com/rust-lang/crates.io-index

    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ security vulnerability detected

@Leavrth
Copy link
Contributor

Leavrth commented Apr 14, 2025

/retest

YuJuncen added 2 commits April 16, 2025 10:28
@YuJuncen
Merge branch 'release-8.5' of https://github.com/tikv/tikv into cherr…
13578cb 
…y-pick-18131-to-release-8.5

Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@YuJuncen
make clippy happy
3a1cdf4 
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@YuJuncen
Copy link
Contributor

YuJuncen commented Apr 16, 2025 

cases::test_in_memory_engine::test_evictions_after_transfer_leader

/retest

@ti-chi-bot ti-chi-bot bot merged commit 519a8e2 into tikv:release-8.5 Apr 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YuJuncen YuJuncen

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @YuJuncen @Leavrth