Skip to content

resolved-ts: skip updating last_pd_tso if tso fetch fails#17990

Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
ekexium:fix-17989
Jan 13, 2025
Merged

resolved-ts: skip updating last_pd_tso if tso fetch fails#17990
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
ekexium:fix-17989

Conversation

@ekexium
Copy link
Contributor

@ekexium ekexium commented Dec 12, 2024 •
edited
Loading

What is changed and how it works?

Issue Number: Close #17989

What's Changed:

If tso fetch fails, skip updating last_pd_tso.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix a potential incorrect metric or log about gaps of resolved-ts

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2024
@ekexium
fix: if tso fetch fails, skip advancing resolved_ts
f40f586 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium requested review from overvenus and zyguan January 2, 2025 05:17
@ekexium ekexium changed the title resolved-ts: skip advancing resolved_ts if tso fetch fails resolved-ts: skip updating last_pd_tso if tso fetch fails Jan 2, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 2, 2025
@ekexium ekexium requested review from crazycs520 and you06 January 7, 2025 06:15
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 13, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 13, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-02 07:16:35.32407772 +0000 UTC m=+593930.680082259: ☑️ agreed by zyguan.
  • 2025-01-13 02:34:39.048769791 +0000 UTC m=+753022.337601500: ☑️ agreed by cfzjywxk.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 13, 2025

@ekexium: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ekexium
Copy link
Contributor Author

ekexium commented Jan 13, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 2f3f32d into tikv:master Jan 13, 2025
1 check passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jan 13, 2025
xzhangxian1008 pushed a commit to xzhangxian1008/tikv that referenced this pull request Feb 8, 2025
@ekexium @ti-chi-bot @xzhangxian1008
resolved-ts: skip updating last_pd_tso if tso fetch fails (tikv#17990)
f6414c2 
close tikv#17989

If tso fetch fails, skip updating last_pd_tso.

Signed-off-by: ekexium <eke@fastmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: xzhangxian1008 <xzhangxian@foxmail.com>
@LykxSassinator LykxSassinator added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 11, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 11, 2025

In response to a cherrypick label: new pull request created to branch release-7.5: #18201.

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Feb 11, 2025
@ti-chi-bot @ekexium
resolved-ts: skip updating last_pd_tso if tso fetch fails (#17990) (#…
93744c9 
…18201)

close #17989

If tso fetch fails, skip updating last_pd_tso.

Signed-off-by: ekexium <eke@fastmail.com>

Co-authored-by: ekexium <eke@fastmail.com>
@ekexium ekexium added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Apr 9, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2025
Open
9 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 9, 2025

In response to a cherrypick label: new pull request created to branch release-8.1: #18369.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 9, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18370.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Apr 16, 2025
@ti-chi-bot @ekexium
resolved-ts: skip updating last_pd_tso if tso fetch fails (#17990) (#…
87a69f5 
…18370)

close #17989

If tso fetch fails, skip updating last_pd_tso.

Signed-off-by: ekexium <eke@fastmail.com>

Co-authored-by: ekexium <eke@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@overvenus overvenus Awaiting requested review from overvenus

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@you06 you06 Awaiting requested review from you06

+1 more reviewer

@zyguan zyguan zyguan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

Logs and metrics pertaining resolved_ts gap can be wrong if TSO fetch fails

5 participants

@ekexium @ti-chi-bot @cfzjywxk @zyguan @LykxSassinator