Skip to content

resolved-ts: skip updating last_pd_tso if tso fetch fails (#17990)#18201

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-7.5from
ti-chi-bot:cherry-pick-17990-to-release-7.5
Feb 11, 2025
Merged

resolved-ts: skip updating last_pd_tso if tso fetch fails (#17990)#18201
ti-chi-bot[bot] merged 1 commit intotikv:release-7.5from
ti-chi-bot:cherry-pick-17990-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Feb 11, 2025

This is an automated cherry-pick of #17990

What is changed and how it works?

Issue Number: Close #17989

What's Changed:

If tso fetch fails, skip updating last_pd_tso.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix a potential incorrect metric or log about gaps of resolved-ts

@ekexium @ti-chi-bot
fix: if tso fetch fails, skip advancing resolved_ts
97393eb 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 11, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 11, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 11, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LykxSassinator,ekexium]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-11 02:58:02.907492439 +0000 UTC m=+325325.303714501: ☑️ agreed by LykxSassinator.
  • 2025-02-11 02:59:10.655822283 +0000 UTC m=+325393.052044342: ☑️ agreed by ekexium.

@ti-chi-bot ti-chi-bot bot merged commit 93744c9 into tikv:release-7.5 Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@ekexium ekexium ekexium approved these changes

Assignees

@ekexium ekexium

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @LykxSassinator @ekexium