Skip to content

resolved-ts: skip updating last_pd_tso if tso fetch fails (#17990)#18370

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-17990-to-release-8.5
Apr 16, 2025
Merged

resolved-ts: skip updating last_pd_tso if tso fetch fails (#17990)#18370
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-17990-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Apr 9, 2025

This is an automated cherry-pick of #17990

What is changed and how it works?

Issue Number: Close #17989

What's Changed:

If tso fetch fails, skip updating last_pd_tso.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix a potential incorrect metric or log about gaps of resolved-ts

@ekexium @ti-chi-bot
fix: if tso fetch fails, skip advancing resolved_ts
650f9af 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Apr 9, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 9, 2025
Merged
9 tasks
@ekexium ekexium requested review from cfzjywxk and zyguan April 9, 2025 06:56
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 10, 2025
@ekexium
Copy link
Contributor

ekexium commented Apr 15, 2025

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 15, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-10 07:34:38.40434938 +0000 UTC m=+2328172.088585476: ☑️ agreed by zyguan.
  • 2025-04-15 08:03:54.248352583 +0000 UTC m=+2761927.932588678: ☑️ agreed by cfzjywxk.

@cfzjywxk
Copy link
Collaborator

cfzjywxk commented Apr 15, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 87a69f5 into tikv:release-8.5 Apr 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

+1 more reviewer

@zyguan zyguan zyguan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ekexium ekexium

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @ekexium @cfzjywxk @zyguan