Skip to content

expression: fix casting REAL type to STRING type (#16975)#17003

Merged
ti-chi-bot[bot] merged 7 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-16975-to-release-8.1
May 13, 2024
Merged

expression: fix casting REAL type to STRING type (#16975)#17003
ti-chi-bot[bot] merged 7 commits intotikv:release-8.1from
ti-chi-bot:cherry-pick-16975-to-release-8.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 11, 2024

This is an automated cherry-pick of #16975

What is changed and how it works?

Issue Number: Close #16974

ref pingcap/tidb#53129

What's Changed:

expression: fix casting REAL type to STRING type
- unify the behavior of converting real types to strings in tidb#53129 and tikv.
- use ryu lib in tikv to implement casting real type to str type.
- `if abs(num) >= 1e15 or (num is not zero and abs(num) < 1e-15)` then use decimal exponent format

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix the incorrect result when casting REAL type to STRING type

solotzg added 7 commits May 11, 2024 10:22
@solotzg @ti-chi-bot
1
a441272 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
2
7131c44 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
3
3ca4320 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
Update Cargo.toml
5b41bbd 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
Update impl_cast.rs
65487e7 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
Update impl_cast.rs
afa98ee 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg @ti-chi-bot
Update impl_cast.rs
24db5a2 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels May 11, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 11, 2024
Merged
9 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@solotzg
Copy link
Contributor

solotzg commented May 13, 2024

ref pingcap/tidb#53207

@solotzg solotzg mentioned this pull request May 13, 2024
Merged
13 tasks
@solotzg
Copy link
Contributor

solotzg commented May 13, 2024

/cc @gengliqi

@ti-chi-bot ti-chi-bot bot requested a review from gengliqi May 13, 2024 02:30
@solotzg
Copy link
Contributor

solotzg commented May 13, 2024

/assign @solotzg

@solotzg
Copy link
Contributor

solotzg commented May 13, 2024

/cc @wshwsh12

@ti-chi-bot ti-chi-bot bot requested a review from wshwsh12 May 13, 2024 04:04
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2024
@gengliqi
Copy link
Member

gengliqi commented May 13, 2024

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 24db5a2

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 13, 2024
@ti-chi-bot ti-chi-bot bot merged commit ca6e66e into tikv:release-8.1 May 13, 2024
@solotzg solotzg mentioned this pull request May 14, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request May 14, 2024
@solotzg
expression: revert #17003 (release-8.1) (#17014)
2501c9a 
close #16974

Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengliqi gengliqi gengliqi approved these changes

+1 more reviewer

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@solotzg solotzg

Labels

cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @solotzg @gengliqi @wshwsh12