Skip to content

expression: unify casting real to string in tidb (tikv#16975) | tidb-test=pr/2324#53129

Merged
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
solotzg:fix-tidb-51109
May 11, 2024
Merged

expression: unify casting real to string in tidb (tikv#16975) | tidb-test=pr/2324#53129
ti-chi-bot[bot] merged 4 commits intopingcap:masterfrom
solotzg:fix-tidb-51109

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented May 9, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #51109

Problem Summary:

  • The default implementation about casting float32/float64 into string is supported by lib strconv. strconv use Ryu algorithm to calculate significant digits.
  • TiKV use method f32::to_string & f64::to_string to implement casting real to str. It can NOT guarantee precision if the number of significant digits exceeds the upper limit (f32: 6, f64: 15).
  • If don't use decimal exponent format, the size of target string might be too large.

What changed and how does it work?

Unify the behavior of converting real types to strings in tidb and tikv(tikv/tikv#16975).

  • use ryu lib in tikv to implement casting real type to str type.
  • if abs(num) >= 1e15 or abs(num) < 1e-15 then use decimal exponent format

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the incorrect result when casting REAL type to STRING type

@solotzg
fix 51109
a0043c4 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2024
@tiprow
Copy link

tiprow bot commented May 9, 2024

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented May 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8800%. Comparing base (ce74191) to head (5e6945f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53129        +/-   ##
================================================
+ Coverage   72.4150%   73.8800%   +1.4649%     
================================================
  Files          1492       1492                
  Lines        429231     429258        +27     
================================================
+ Hits         310828     317136      +6308     
+ Misses        99123      92184      -6939     
- Partials      19280      19938       +658
Flag Coverage Δ
integration 26.2688% <77.4193%> (?)
unit 71.2438% <100.0000%> (-0.0653%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.1840% <ø> (+8.7438%) ⬆️

@solotzg
1
3b25ed6 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg
Copy link
Contributor Author

solotzg commented May 9, 2024

/retest

@tiprow
Copy link

tiprow bot commented May 9, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg
Copy link
Contributor Author

solotzg commented May 9, 2024

/test mysql-test

@tiprow
Copy link

tiprow bot commented May 9, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg solotzg changed the title [WIP] expression: unify casting real to string in tidb expression: unify casting real to string in tidb | tidb-test=pr/2324 May 9, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
@solotzg
Copy link
Contributor Author

solotzg commented May 9, 2024

/retest

@tiprow
Copy link

tiprow bot commented May 9, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg
Copy link
Contributor Author

solotzg commented May 9, 2024

/retest

@tiprow
Copy link

tiprow bot commented May 9, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@solotzg solotzg mentioned this pull request May 9, 2024
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 9, 2024
@solotzg
Copy link
Contributor Author

solotzg commented May 9, 2024

/cc @wshwsh12 @XuHuaiyu

@ti-chi-bot ti-chi-bot bot requested review from XuHuaiyu and wshwsh12 May 9, 2024 14:15
@solotzg
2
3e43990 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 10, 2024

@gengliqi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@solotzg solotzg changed the title expression: unify casting real to string in tidb | tidb-test=pr/2324 expression: unify casting real to string in tidb (tikv#16975) | tidb-test=pr/2324 May 11, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 11, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 11, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-11 09:22:54.058931214 +0000 UTC m=+1299527.816066789: ☑️ agreed by XuHuaiyu.
  • 2024-05-11 09:24:33.870458489 +0000 UTC m=+1299627.627594061: ☑️ agreed by wshwsh12.

@solotzg
Copy link
Contributor Author

solotzg commented May 11, 2024

/test mysql-test

@tiprow
Copy link

tiprow bot commented May 11, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced May 11, 2024
Closed
Closed
Closed
Closed
Closed
Merged
@ti-chi-bot ti-chi-bot bot merged commit f311d77 into pingcap:master May 11, 2024
@solotzg solotzg deleted the fix-tidb-51109 branch May 11, 2024 10:30
@solotzg
Copy link
Contributor Author

solotzg commented May 13, 2024

/cherrypick release-8.1

@ti-chi-bot ti-chi-bot mentioned this pull request May 13, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2024

@solotzg: new pull request created to branch release-8.1: #53207.

Details

In response to this:

/cherrypick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request May 13, 2024
@ti-chi-bot
expression: unify casting real to string in tidb (tikv#16975) | tidb-…
6b7a5ec 
…test=pr/2325 (#53129) (#53207)

close #51109
solotzg added a commit to solotzg/tidb that referenced this pull request May 14, 2024
@solotzg
Revert "expression: unify casting real to string in tidb (tikv#16975) (…
ec849d1 
…pingcap#53129)"

This reverts commit f311d77.
@solotzg solotzg mentioned this pull request May 14, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 14, 2024
@solotzg
expression: reverts #53129 (#53259)
045a5b5 
close #53248
@solotzg solotzg mentioned this pull request May 15, 2024
Closed
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@solotzg @terry1purcell
expression: unify casting real to string in tidb (tikv#16975) (pingca…
e655825 
…p#53129)

close pingcap#51109
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@solotzg @terry1purcell
expression: reverts pingcap#53129 (pingcap#53259)
bac7f20 
close pingcap#53248
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
@solotzg @RidRisR
expression: unify casting real to string in tidb (tikv#16975) (pingca…
fe64514 
…p#53129)

close pingcap#51109
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
@solotzg @RidRisR
expression: reverts pingcap#53129 (pingcap#53259)
f796414 
close pingcap#53248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

+1 more reviewer

@gengliqi gengliqi gengliqi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

query with distinct gets a unexpected result

5 participants

@solotzg @ti-chi-bot @XuHuaiyu @wshwsh12 @gengliqi