Skip to content

expression: reverts #53129 | tidb-test=pr/2329#53259

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
solotzg:revert-53129-fix-tidb-51109
May 14, 2024
Merged

expression: reverts #53129 | tidb-test=pr/2329#53259
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
solotzg:revert-53129-fix-tidb-51109

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented May 14, 2024 •
edited
Loading

Reverts #53129

What problem does this PR solve?

Issue Number: close #53248

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2024
@solotzg solotzg changed the title Revert "expression: unify casting real to string in tidb (tikv#16975) | tidb-test=pr/2324" Revert "expression: unify casting real to string in tidb (tikv#16975) | tidb-test=pr/2329" May 14, 2024
@tiprow
Copy link

tiprow bot commented May 14, 2024

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 14, 2024
@solotzg solotzg changed the title Revert "expression: unify casting real to string in tidb (tikv#16975) | tidb-test=pr/2329" expression: reverts #53129 | tidb-test=pr/2329 May 14, 2024
@solotzg
Copy link
Contributor Author

solotzg commented May 14, 2024

/retest

@tiprow
Copy link

tiprow bot commented May 14, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label May 14, 2024
@codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5619%. Comparing base (a2037fe) to head (ec849d1).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53259        +/-   ##
================================================
+ Coverage   72.4460%   74.5619%   +2.1159%     
================================================
  Files          1493       1493                
  Lines        429361     429778       +417     
================================================
+ Hits         311055     320451      +9396     
+ Misses        99031      89440      -9591     
- Partials      19275      19887       +612
Flag Coverage Δ
integration 49.1431% <100.0000%> (?)
unit 71.2627% <100.0000%> (-0.0796%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4517% <ø> (+9.0215%) ⬆️

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 14, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-14 09:47:44.617979634 +0000 UTC m=+1560218.375115191: ☑️ agreed by XuHuaiyu.
  • 2024-05-14 09:52:46.624617815 +0000 UTC m=+1560520.381753388: ☑️ agreed by guo-shaoge.

@solotzg
Copy link
Contributor Author

solotzg commented May 14, 2024

/retest

@tiprow
Copy link

tiprow bot commented May 14, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 045a5b5 into pingcap:master May 14, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 14, 2024

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-53259-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-53259-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 14, 2024

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-53259-to-release-8.1: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.1 and ti-chi-bot:cherry-pick-53259-to-release-8.1"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

@solotzg solotzg deleted the revert-53129-fix-tidb-51109 branch May 14, 2024 11:40
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 17, 2024
@solotzg @terry1purcell
expression: reverts pingcap#53129 (pingcap#53259)
bac7f20 
close pingcap#53248
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
@solotzg @RidRisR
expression: reverts pingcap#53129 (pingcap#53259)
f796414 
close pingcap#53248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

select cast(3.40282e37 as char) result is changed in master

4 participants

@solotzg @ti-chi-bot @guo-shaoge @XuHuaiyu