Skip to content

expression: revert tikv#17003 (release-8.1)#17014

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-8.1from
solotzg:revert-17003-cherry-pick-16975-to-release-8.1
May 14, 2024
Merged

expression: revert tikv#17003 (release-8.1)#17014
ti-chi-bot[bot] merged 1 commit intotikv:release-8.1from
solotzg:revert-17003-cherry-pick-16975-to-release-8.1

Conversation

@solotzg
Copy link
Contributor

@solotzg solotzg commented May 14, 2024

Reverts #17003

What is changed and how it works?
Issue Number: Close #16974

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 14, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gengliqi
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels May 14, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 14, 2024
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. and removed do-not-merge/cherry-pick-not-approved labels May 14, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

Hi @solotzg. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 14, 2024
@solotzg solotzg changed the title expression: revert tikv#17003 expression: revert tikv#17003 in release-8.1 May 14, 2024
@solotzg solotzg changed the title expression: revert tikv#17003 in release-8.1 expression: revert tikv#17003 (release-8.1) May 14, 2024
@solotzg
revert
fa71f3e 
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg solotzg force-pushed the revert-17003-cherry-pick-16975-to-release-8.1 branch from e482a5b to fa71f3e Compare May 14, 2024 09:43
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 14, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 14, 2024
@gengliqi
Copy link
Member

gengliqi commented May 14, 2024

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

@gengliqi: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 14, 2024

This pull request has been accepted and is ready to merge.

DetailsCommit hash: fa71f3e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit 2501c9a into tikv:release-8.1 May 14, 2024
@solotzg solotzg deleted the revert-17003-cherry-pick-16975-to-release-8.1 branch May 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengliqi gengliqi gengliqi approved these changes

+1 more reviewer

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@solotzg @gengliqi @wshwsh12 @ti-chi-bot