Feature/adr075 backport eventlog#9470
Merged
sergio-mena merged 2 commits intotendermint:feature/adr075-backportfrom Sep 23, 2022
Merged
Feature/adr075 backport eventlog#9470sergio-mena merged 2 commits intotendermint:feature/adr075-backportfrom
sergio-mena merged 2 commits intotendermint:feature/adr075-backportfrom
Conversation
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far.
sergio-mena
approved these changes
Sep 21, 2022
Contributor
sergio-mena
left a comment
There was a problem hiding this comment.
From a purely back-porting perspective, this LGTM
| items to arrive at the head of the log. If `wait_time` is zero or negative, the | ||
| server will wait for a default (positive) interval. | ||
| items to arrive at the head of the log. If `wait_time` is zero, the server will | ||
| return whatever eligible items are available immediately. |
Contributor
There was a problem hiding this comment.
The original PR had many hunks not present here. I went through them and they are all included already (probably because the ADRs on main were copied from master.
So all good here.
| // | ||
| // Any error reported by Add arises from pruning; the new item was added to the | ||
| // log regardless whether an error occurs. | ||
| func (lg *Log) Add(etype string, data types.TMEventData) error { |
Contributor
There was a problem hiding this comment.
Author
Contributor
There was a problem hiding this comment.
Thanks for the answer.
I see there is a series of "rpc cleanup" PRs by Michael that were merged to v0.36.x (and are therefore not in main or feature/adr075-backport). We might want to make sure ADR075-related PRs to backport are not assuming functionality introduced/changed/improved by those cleanup PRs.
3 tasks
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
* rpc: implement the eventlog defined by ADR 075 (tendermint#7825) Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far. * fix event type Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
* rpc: implement the eventlog defined by ADR 075 (tendermint#7825) Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far. * fix event type Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7825 for a full description
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed