types: rename and extend the EventData interface#7687
Merged
creachadair merged 5 commits intomasterfrom Jan 26, 2022
Merged
Conversation
05769bd to
9198dee
Compare
cmwaters
reviewed
Jan 26, 2022
8867f6b to
14bf862
Compare
tychoish
approved these changes
Jan 26, 2022
38f760a to
dda8a80
Compare
added 3 commits
January 26, 2022 06:23
This is the interface shared by types that can be used as event data in, for example, subscriptions via the RPC. To be compatible with the RPC service, data need to support JSON encoding. Require this as part of the interface. Fully propagating this change will require updating the method signatures for the pubsub package too. For now, to keep this change more self-contained, I have inserted type assertions with error checks in the RPC subscription handlers.
dda8a80 to
62ff916
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the interface shared by types that can be used as event data in, for
example, subscriptions via the RPC.
To be compatible with the RPC service, data need to support JSON encoding.
Require this as part of the interface.
This is a precursor to further refactoring between pubsub/RPC.