rpc: implement the eventlog defined by ADR 075#7825
Merged
creachadair merged 10 commits intomasterfrom Feb 21, 2022
Merged
Conversation
9647376 to
fa88498
Compare
tychoish
reviewed
Feb 17, 2022
|
|
||
| // updateHead replaces the current head with newHead, signals any waiters, and | ||
| // resets the wait signal. The caller must hold log.mu exclusively. | ||
| func (lg *Log) updateHead(newHead *logEntry) { |
Author
There was a problem hiding this comment.
It does. As noted in the comment, the caller has to hold it. But we don't want a separate mutex for it.
Author
There was a problem hiding this comment.
(I gave it a name mainly for documentation purposes; I could just inline it if you find that easier to read)
c5b43e9 to
31d74d7
Compare
53d704f to
a81db59
Compare
41066a5 to
f3f8eb1
Compare
added 7 commits
February 21, 2022 07:50
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later.
- Update semantics of event log window. - Update documentation for long polling. - Update JSON tags to match the implementation. - Update config variable names to match the implementation.
f3f8eb1 to
3635f94
Compare
added 2 commits
February 21, 2022 08:19
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 26, 2022
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 26, 2022
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Aug 30, 2022
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Sep 13, 2022
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far.
mmsqe
pushed a commit
to mmsqe/tendermint
that referenced
this pull request
Sep 21, 2022
Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far.
3 tasks
sergio-mena
pushed a commit
that referenced
this pull request
Sep 23, 2022
* rpc: implement the eventlog defined by ADR 075 (#7825) Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far. * fix event type Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
* rpc: implement the eventlog defined by ADR 075 (tendermint#7825) Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far. * fix event type Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
mmsqe
added a commit
to mmsqe/tendermint
that referenced
this pull request
Dec 9, 2022
* rpc: implement the eventlog defined by ADR 075 (tendermint#7825) Implement the basic cursor and eventlog types described in ADR 075. Handle encoding and decoding as strings for compatibility with JSON. - Add unit tests for the required order and synchronization properties. - Add hooks for metrics, with one value to be expanded later. - Update ADR 075 to match the specifics of the implementation so far. * fix event type Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the basic cursor and eventlog types described in ADR 075. Handle
encoding and decoding as strings for compatibility with JSON.
Note to reviewers
This is the largest single unit of the implementation. This PR does not include the plumbing to make the ADR 075 events interface usable. That will follow in subsequent PRs.
There are two packages here to consider: internal/eventlog and internal/eventlog/cursor. The latter is a subsidiary of the former, so I recommend starting with internal/eventlog.
Design notes