Merged
Conversation
Contributor
Author
|
I added two lines to doc.go test 03 fails intermittently, I think I can get it to pass without changing any code. |
Contributor
Author
|
eventually, it will just get a green tick |
Contributor
Author
|
and it passes so basically, we probably shouldn't trust ci right now |
Contributor
|
Please separate out the |
b7319f7 to
f0c255e
Compare
sergio-mena
approved these changes
Aug 10, 2022
thanethomson
approved these changes
Aug 10, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 11, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 11, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 12, 2022
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let me know if I should update CHANGELONG_PENDING.md
This only removes ioutil, which has been deprecated since go 1.16 --
all other changes can be eliminated by merging:
The other changes were needed only to get ci to pass.
By dropping the use of io/ioutil, it makes developers using go 1.19 and golangci-lint 1.48.0 not get many, many deprecation warnings.
Note: bet I can make tests pass for no reason by just doing golangci-lint run ./... --fix on this branch
that won't change anything other than formatting.
note about these pr's
They're basically remote-diagnosis of the ci system, which is why there's many of them, they touch many files, and they're similar.
Fairly sure at this point that we've got an intermittent test failure that we can just step aside by tossing in an additional commit.
The suspect tests are:
TestBroadcastTxForPeerStopsWhenReactorStops
TestNodeNewNodeCustomReactors
Note that:
d788043
passes, except for the linter. Its diff from the prior commit should be two additional lines in node/doc.go
I did this twice:
fa8e382
passes, except for the linter. Its diff from the prior commit is two lines added to node/doc.go
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed