Skip to content

do not use ioutil#9206

Merged
thanethomson merged 2 commits intotendermint:mainfrom
notional-labs:deprecate-ioutil
Aug 10, 2022
Merged

do not use ioutil#9206
thanethomson merged 2 commits intotendermint:mainfrom
notional-labs:deprecate-ioutil

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Aug 9, 2022

Please let me know if I should update CHANGELONG_PENDING.md

This only removes ioutil, which has been deprecated since go 1.16 --

all other changes can be eliminated by merging:

The other changes were needed only to get ci to pass.

By dropping the use of io/ioutil, it makes developers using go 1.19 and golangci-lint 1.48.0 not get many, many deprecation warnings.

Note: bet I can make tests pass for no reason by just doing golangci-lint run ./... --fix on this branch

that won't change anything other than formatting.

note about these pr's

They're basically remote-diagnosis of the ci system, which is why there's many of them, they touch many files, and they're similar.

Fairly sure at this point that we've got an intermittent test failure that we can just step aside by tossing in an additional commit.

The suspect tests are:

TestBroadcastTxForPeerStopsWhenReactorStops
TestNodeNewNodeCustomReactors

Note that:

d788043

passes, except for the linter. Its diff from the prior commit should be two additional lines in node/doc.go

I did this twice:

fa8e382

passes, except for the linter. Its diff from the prior commit is two lines added to node/doc.go


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@faddat faddat requested a review from ebuchman as a code owner August 9, 2022 17:13
@faddat faddat requested a review from a team August 9, 2022 17:13
@faddat faddat mentioned this pull request Aug 9, 2022
3 tasks
@faddat
Copy link
Contributor Author

faddat commented Aug 9, 2022

I added two lines to doc.go

test 03 fails intermittently, I think I can get it to pass without changing any code.

@faddat
Copy link
Contributor Author

faddat commented Aug 9, 2022

eventually, it will just get a green tick

@faddat
Copy link
Contributor Author

faddat commented Aug 9, 2022

and it passes

so basically, we probably shouldn't trust ci right now

@thanethomson
Copy link
Contributor

Please separate out the ioutil removal changes from the rest of the linting/tooling-related changes.

@thanethomson thanethomson merged commit a6dde14 into tendermint:main Aug 10, 2022
samricotta pushed a commit that referenced this pull request Aug 11, 2022
samricotta pushed a commit that referenced this pull request Aug 11, 2022
samricotta pushed a commit that referenced this pull request Aug 12, 2022
samricotta pushed a commit that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants