Skip to content

goimports, gofmt -> gofumpt#9207

Closed
faddat wants to merge 4 commits intotendermint:mainfrom
faddat:patch-7
Closed

goimports, gofmt -> gofumpt#9207
faddat wants to merge 4 commits intotendermint:mainfrom
faddat:patch-7

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Aug 9, 2022

Gofumpt replaces both gofmt and goimports, and does better at both.

Afterwards, I run make format

note about these pr's

They're basically remote-diagnosis of the ci system, which is why there's many of them, they touch many files, and they're similar.

Fairly sure at this point that we've got an intermittent test failure that we can just step aside by tossing in an additional commit.


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@faddat faddat requested a review from ebuchman as a code owner August 9, 2022 17:19
@faddat faddat requested a review from a team August 9, 2022 17:19
@faddat faddat changed the title Update Makefile goimports, gofmt -> gofumpt Aug 9, 2022
This was referenced Aug 9, 2022
@faddat faddat closed this Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant