Skip to content

golangci linting#9208

Closed
faddat wants to merge 4 commits intotendermint:mainfrom
notional-labs:golangci-lint
Closed

golangci linting#9208
faddat wants to merge 4 commits intotendermint:mainfrom
notional-labs:golangci-lint

Conversation

@faddat
Copy link
Contributor

@faddat faddat commented Aug 9, 2022

Modernizes the approach to golangci:

But it seems that make proto-gen is broken

In cosmos, intermittent test failures are common. I thought this came from the sdk, but maybe it's coming from tendermint, as I've seen a few tonight.

2nd thought on the test failures: I guess building the sdk doesn't run the same tests? This is a high-value mystery imo

3rd thought: we've got intermittent test failures in this repo, proof:

e25196d

5d6da11

...should not have different test outcomes.

note about these pr's

They're basically remote-diagnosis of the ci system, which is why there's many of them, they touch many files, and they're similar.

Fairly sure at this point that we've got an intermittent test failure that we can just step aside by tossing in an additional commit.


PR checklist

  • Tests written/updated, or no tests needed
  • CHANGELOG_PENDING.md updated, or no changelog entry needed
  • Updated relevant documentation (docs/) and code comments, or no
    documentation updates needed

@faddat faddat requested a review from ebuchman as a code owner August 9, 2022 17:53
@faddat faddat requested a review from a team August 9, 2022 17:53
@faddat faddat mentioned this pull request Aug 9, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant