abci: PrepareProposal by tac0turtle · Pull Request #6544 · tendermint/tendermint

tac0turtle · 2021-06-07T12:07:02Z

Description

PrepareProposal implementation.

TODO:

modify apps
fix tests
modify e2e

ref #6066

cc @ValarDragon

codecov · 2021-06-07T13:43:21Z

Codecov Report

Merging #6544 (26de7e9) into abci++ (c3ae6f5) will decrease coverage by 1.97%.
The diff coverage is 0.00%.

❗ Current head 26de7e9 differs from pull request most recent head a6f5205. Consider uploading reports for the commit a6f5205 to get more accurate results

@@            Coverage Diff             @@
##           abci++    #6544      +/-   ##
==========================================
- Coverage   62.39%   60.41%   -1.98%     
==========================================
  Files         298      299       +1     
  Lines       39991    27943   -12048     
==========================================
- Hits        24951    16881    -8070     
+ Misses      13269     9344    -3925     
+ Partials     1771     1718      -53

Impacted Files	Coverage Δ
abci/client/client.go	`32.35% <ø> (-3.82%)`	⬇️
abci/client/grpc_client.go	`0.00% <0.00%> (ø)`
abci/client/local_client.go	`0.00% <0.00%> (ø)`
abci/client/socket_client.go	`37.26% <0.00%> (-3.30%)`	⬇️
abci/example/kvstore/kvstore.go	`67.07% <0.00%> (-6.97%)`	⬇️
abci/example/kvstore/persistent_kvstore.go	`39.83% <0.00%> (-9.86%)`	⬇️
abci/types/application.go	`0.00% <0.00%> (ø)`
abci/types/messages.go	`7.24% <0.00%> (+1.69%)`	⬆️
proxy/app_conn.go	`20.51% <0.00%> (-6.16%)`	⬇️
state/execution.go	`66.05% <0.00%> (+0.73%)`	⬆️
... and 390 more

tac0turtle · 2021-06-07T13:47:12Z

Blocked on spec version release.

tac0turtle · 2021-06-07T13:49:07Z

@ValarDragon in one section of the RFC you mention sending only blockdata (txs) but in a different section you mention also the header.

Could you double-check this is right?

ValarDragon · 2021-06-07T16:17:54Z

The header should came after vote extensions are built, right now it should just have the tx data

tessr · 2021-06-07T20:47:50Z

(does this PR have the right name?)

cmwaters

This seems like a relative straight forward PR to me.

Since PrepareProposal also acts like a CheckTx, do you think it would be possible to remove or adjust the way we RecheckTx after every block

state/execution.go

abci/client/grpc_client.go

abci/client/local_client.go

abci/client/socket_client.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com>

test/e2e/app/app.go

liamsi

This is dope 👍🏼

github-actions · 2021-07-02T00:08:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

alexanderbez

Looks good @marbar3778! Left a bit of small feedback.

alexanderbez · 2021-07-15T13:24:12Z

abci/example/kvstore/persistent_kvstore.go

+	if len(req.BlockData) >= 1 {
+		req.BlockData[1] = []byte("modified tx")
+	}


Maybe add a quick comment on what we're doing here in this example.

internal/consensus/mempool_test.go

proto/tendermint/abci/types.proto

test/e2e/app/app.go

types/tx.go

state/execution.go

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

github-actions · 2021-07-26T00:07:49Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

* [Rebased to v0.34.x] abci: PrepareProposal (#6544) * fixed cherry-pick * proto changes * make proto-gen * UT fixes * generate Client directive * mockery * App fixes * Disable 'modified tx' hack * mockery * Make format * Fix lint Co-authored-by: Marko <marbar3778@yahoo.com>

* abci: PrepareProposal (tendermint#6544) * regenerate mocks, proto, mod/sum, and clean up remaining preprocesstxs * fix tests and revert to old go.mod * mockery * add processproposal proto/boilerplate/logic * gofmt * fix test * move UNKNOWN response behaviour to reject * fix test and add testing util code * pass full block data when proposing or processing proposals * linter * add the process proposal method to the e2e app * add missing kvstore abci method * pass block data and results for bass app * use correct kvstore process logic for kvstore app * remove linting comment Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * formatting Co-authored-by: John Adler <adlerjohn@users.noreply.github.com> * use go generate instead of make mockery * add link Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: mconcat <monoidconcat@gmail.com> Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>

* abci: PrepareProposal (tendermint#6544) * regenerate mocks, proto, mod/sum, and clean up remaining preprocesstxs * fix tests and revert to old go.mod * mockery * add processproposal proto/boilerplate/logic * gofmt * fix test * move UNKNOWN response behaviour to reject * fix test and add testing util code * pass full block data when proposing or processing proposals * linter * add the process proposal method to the e2e app * add missing kvstore abci method * pass block data and results for bass app * use correct kvstore process logic for kvstore app * add new lazy share writers * linter * remove unused arg * sort messages before exporting * formatting and bug fix * fix tests * allow for picking of square size when computing shares for the data square * remove accidental code duplication * fix test from using wrong formatting directive * linter * ci: backport lint configuration changes (tendermint#7225) * lint: cleanup pending lint errors (tendermint#7237) * linter * remove unused arg * sort messages before exporting * formatting and bug fix * fix tests * allow for picking of square size when computing shares for the data square * fix test from using wrong formatting directive * linter * ci: backport lint configuration changes (tendermint#7225) * lint: cleanup pending lint errors (tendermint#7237) * add new lazy share writers * fix rebase * linter * try ci with go 1.17 * Revert "try ci with go 1.17" This reverts commit 0f76b4d444465cf8209bd98bb18f21b242207436. * please work, linter gods * spelling Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com> * initialize pending share using the const share size for capacity * force the last reserve bytes to be zero * remove todo * add typecheck back to golang linter * Revert "ci: backport lint configuration changes (tendermint#7225)" This reverts commit 35178048f0fef2d80a0346f28c7687be75c3db11. * Revert "lint: cleanup pending lint errors (tendermint#7237)" This reverts commit 5d806709a9dbfed4f7dda2facb49d46604584d36. * add the link to issue back in * removed unfinished comment * switch fuzzer back to one minute * regenerate proto * better docs * fix encoding check to include the hash added to Data * add docs to CotiguousShareWriter * fix encoding check * explain why the share reserve byte is zero * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use clearer wording for compute shares docs * more accurate docs Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: mconcat <monoidconcat@gmail.com> Co-authored-by: Sam Kleinman <garen@tychoish.com> Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com> Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>

tac0turtle added 2 commits June 7, 2021 13:43

generate proto files

f6ad007

modify proxy and execution

459879b

tac0turtle added the C:abci Component: Application Blockchain Interface label Jun 7, 2021

tac0turtle self-assigned this Jun 7, 2021

tac0turtle added 5 commits June 7, 2021 14:07

Merge branch 'abci++' into preProcesProposal

5d64e48

regenerate mockery

557e29c

add prepare to kvstore and e2e tests

25e5fcb

fix counter

ab4ab0e

fix sizing

26de7e9

tac0turtle marked this pull request as ready for review June 7, 2021 13:46

tac0turtle requested review from alexanderbez, cmwaters, ebuchman, tessr and tychoish as code owners June 7, 2021 13:46

tac0turtle added the S:blocked Status: Blocked (link to issue which is needed to unblock) label Jun 7, 2021

tac0turtle changed the title ~~abci: Preproces proposal~~ abci: PrepareProposal Jun 7, 2021

cmwaters approved these changes Jun 10, 2021

View reviewed changes

state/execution.go Outdated Show resolved Hide resolved

state/execution.go Outdated Show resolved Hide resolved

state/execution.go Outdated Show resolved Hide resolved

alexanderbez reviewed Jun 10, 2021

View reviewed changes

tac0turtle and others added 2 commits June 17, 2021 07:37

Apply suggestions from code review

67cb74d

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com>

Merge branch 'abci++' into preProcesProposal

a27b497

liamsi reviewed Jun 21, 2021

View reviewed changes

test/e2e/app/app.go Show resolved Hide resolved

liamsi reviewed Jun 21, 2021

View reviewed changes

commit

a72ed8b

add comment opn contract

38b5f66

alexanderbez approved these changes Jul 15, 2021

View reviewed changes

tac0turtle and others added 6 commits July 15, 2021 14:40

Update types/tx.go

aefca33

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Update state/execution.go

a43a849

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Update state/execution.go

6b84c4b

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

Update state/execution.go

b6660d2

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

add nolint and comments

3b241fc

Update types/tx.go

e7529c0

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

liamsi mentioned this pull request Jul 16, 2021

Proposal: Immediate execution to accomodate ISRs celestiaorg/celestia-core#463

Closed

github-actions bot added the stale for use by stalebot label Jul 26, 2021

tac0turtle removed the stale for use by stalebot label Jul 26, 2021

tac0turtle added 3 commits July 26, 2021 09:59

add size of allowed txs

e026121

Merge branch 'abci++' into preProcesProposal

ef32361

add comment

a6f5205

tac0turtle merged commit 7d30987 into abci++ Jul 27, 2021

tac0turtle deleted the preProcesProposal branch July 27, 2021 07:30

sergio-mena pushed a commit that referenced this pull request Jan 31, 2022

abci: PrepareProposal (#6544)

a9e846c

sergio-mena mentioned this pull request Feb 1, 2022

Rebased branch abci++ to tip of master #7746

Merged

sergio-mena pushed a commit that referenced this pull request Feb 2, 2022

abci: PrepareProposal (#6544)

68509fd

sergio-mena pushed a commit that referenced this pull request Feb 2, 2022

abci: PrepareProposal (#6544)

ff498ff

evan-forbes mentioned this pull request Feb 16, 2022

Add Prepare and Process Proposal ABCI++ methods celestiaorg/celestia-core#631

Merged

This was referenced Jul 22, 2022

ABCI++ Prepare/Process Proposal #9053

Closed

Old PrepareProposal #9104

Closed

sergio-mena pushed a commit that referenced this pull request Jul 27, 2022

[Rebased to v0.34.x] abci: PrepareProposal (#6544)

731bc16

sergio-mena mentioned this pull request Jul 27, 2022

Old PrepareProposal on feature/abci++ppp #9106

Merged

Conversation

tac0turtle commented Jun 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

codecov bot commented Jun 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tac0turtle commented Jun 7, 2021

Uh oh!

tac0turtle commented Jun 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ValarDragon commented Jun 7, 2021

Uh oh!

tessr commented Jun 7, 2021

Uh oh!

cmwaters left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

liamsi left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 2, 2021

Uh oh!

alexanderbez left a comment

Choose a reason for hiding this comment

Uh oh!

alexanderbez Jul 15, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tac0turtle commented Jun 7, 2021 •

edited

Loading

codecov bot commented Jun 7, 2021 •

edited

Loading

tac0turtle commented Jun 7, 2021 •

edited

Loading