lint: cleanup pending lint errors #7237
Merged
tychoish merged 9 commits intotendermint:v0.34.xfrom Nov 4, 2021
Merged
Conversation
Contributor
|
I think some of these errors is because we only introduces stricter spelling conditions in 0.35 onwards (i.e. American English) |
Contributor
Author
The more confusing thing is that all of the remaining issues seem to be |
Contributor
|
I have a feeling that the linter doesn't update until after the PR is merged so it still has all the old linting settings |
Contributor
Author
|
looks like it worked though! |
cmwaters
pushed a commit
to cmwaters/tendermint
that referenced
this pull request
Dec 12, 2022
* abci: PrepareProposal (tendermint#6544) * regenerate mocks, proto, mod/sum, and clean up remaining preprocesstxs * fix tests and revert to old go.mod * mockery * add processproposal proto/boilerplate/logic * gofmt * fix test * move UNKNOWN response behaviour to reject * fix test and add testing util code * pass full block data when proposing or processing proposals * linter * add the process proposal method to the e2e app * add missing kvstore abci method * pass block data and results for bass app * use correct kvstore process logic for kvstore app * add new lazy share writers * linter * remove unused arg * sort messages before exporting * formatting and bug fix * fix tests * allow for picking of square size when computing shares for the data square * remove accidental code duplication * fix test from using wrong formatting directive * linter * ci: backport lint configuration changes (tendermint#7225) * lint: cleanup pending lint errors (tendermint#7237) * linter * remove unused arg * sort messages before exporting * formatting and bug fix * fix tests * allow for picking of square size when computing shares for the data square * fix test from using wrong formatting directive * linter * ci: backport lint configuration changes (tendermint#7225) * lint: cleanup pending lint errors (tendermint#7237) * add new lazy share writers * fix rebase * linter * try ci with go 1.17 * Revert "try ci with go 1.17" This reverts commit 0f76b4d444465cf8209bd98bb18f21b242207436. * please work, linter gods * spelling Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com> * initialize pending share using the const share size for capacity * force the last reserve bytes to be zero * remove todo * add typecheck back to golang linter * Revert "ci: backport lint configuration changes (tendermint#7225)" This reverts commit 35178048f0fef2d80a0346f28c7687be75c3db11. * Revert "lint: cleanup pending lint errors (tendermint#7237)" This reverts commit 5d806709a9dbfed4f7dda2facb49d46604584d36. * add the link to issue back in * removed unfinished comment * switch fuzzer back to one minute * regenerate proto * better docs * fix encoding check to include the hash added to Data * add docs to CotiguousShareWriter * fix encoding check * explain why the share reserve byte is zero * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use punctuation Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * use clearer wording for compute shares docs * more accurate docs Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: mconcat <monoidconcat@gmail.com> Co-authored-by: Sam Kleinman <garen@tychoish.com> Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com> Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for v0.34.x