Old PrepareProposal on feature/abci++ppp#9106
Merged
sergio-mena merged 12 commits intofeature/abci++pppfrom Jul 27, 2022
Merged
Old PrepareProposal on feature/abci++ppp#9106sergio-mena merged 12 commits intofeature/abci++pppfrom
sergio-mena merged 12 commits intofeature/abci++pppfrom
Conversation
cmwaters
approved these changes
Jul 27, 2022
Contributor
cmwaters
left a comment
There was a problem hiding this comment.
This looks good to me as a preliminary change
Contributor
Author
|
Closes #9104 |
Closed
samricotta
pushed a commit
that referenced
this pull request
Aug 16, 2022
* [Rebased to v0.34.x] abci: PrepareProposal (#6544) * fixed cherry-pick * proto changes * make proto-gen * UT fixes * generate Client directive * mockery * App fixes * Disable 'modified tx' hack * mockery * Make format * Fix lint Co-authored-by: Marko <marbar3778@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was done via a longer way (more conflicts) by cherry-picking #7746, rather than #6544 (which would have been simpler).
The reason is that this work was already done 2 weeks ago, for estimating ABCI++ Option 2 in the Q3 planning document.
So, we are reusing this work on branch
feature/abci++ppp