json: add Amino-compatible encoder/decoder#4955
Merged
mergify[bot] merged 34 commits intomasterfrom Jun 8, 2020
Merged
Conversation
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #4955 +/- ##
==========================================
+ Coverage 63.26% 63.46% +0.20%
==========================================
Files 187 176 -11
Lines 19647 16509 -3138
==========================================
- Hits 12429 10477 -1952
+ Misses 6225 5150 -1075
+ Partials 993 882 -111
|
erikgrinaker
commented
Jun 5, 2020
tac0turtle
reviewed
Jun 5, 2020
Contributor
tac0turtle
left a comment
There was a problem hiding this comment.
utACK but would like to get some more eyes on it.
liamsi
reviewed
Jun 5, 2020
Contributor
liamsi
left a comment
There was a problem hiding this comment.
I really like this approach 🙌 Left a few nits, mostly about the necessity to highlight a few edge-cases in a package documentation.
liamsi
reviewed
Jun 5, 2020
melekes
reviewed
Jun 7, 2020
Contributor
melekes
left a comment
There was a problem hiding this comment.
great work @erikgrinaker 👍
melekes
approved these changes
Jun 8, 2020
liamsi
reviewed
Jun 8, 2020
mergify bot
pushed a commit
that referenced
this pull request
Jun 8, 2020
Migrates the `rpc` package to use new JSON encoder in #4955. Branched off of that PR. Tests pass, but I haven't done any manual testing beyond that. This should be handled as part of broader 0.34 testing.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amino-compatible JSON encoder/decoder, including bug compatibility. Interface types must be registered via
json.RegisterType(). Unlike Amino, this allows floats to be encoded/decoded.Partial fix for #4828, needs code migration.