-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Description
This is meant as a tracking issue for some places where json encoding will change and effect the developer.
Summary
Currently amino is used for JSON encoding. With the move to protobuf this is not possible anymore. encoding/json & gogo/protobuf/jsonpb encode things differently. We will have to rely on jsonpb for JSON encoding in Tendermint. The json will be encoded following the protobuf json spec https://developers.google.com/protocol-buffers/docs/proto3#json
Tracking for things that will need to change
- wal2json & json2wal
- RPC
- privval (.json) files
Options:- Write a script to migrate keys to oneof encoding. This will take in the
privval_key.sjonand replace it with the encoding which is consistent with oneof - Keep backward compatibility
- Write a script to migrate keys to oneof encoding. This will take in the
- Genesis
- no need for backwards compatability here as chains will have to restart for this change. Although a script to aid in genesis migration may make upgrading a bit easier
For Admin Use
- Not duplicate issue
- Appropriate labels applied
- Appropriate contributors tagged
- Contributor assigned/self-assigned
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
T:encodingType: Amino, ProtoBufType: Amino, ProtoBuf