Skip to content

migrate all JSON to new JSON encoder#4975

Merged
mergify[bot] merged 10 commits intomasterfrom
erik/migrate-json
Jun 8, 2020
Merged

migrate all JSON to new JSON encoder#4975
mergify[bot] merged 10 commits intomasterfrom
erik/migrate-json

Conversation

@erikgrinaker
Copy link
Contributor

Uses new JSON encoder in #4955 for all JSON. Branched off of #4968.

@erikgrinaker erikgrinaker added the T:encoding Type: Amino, ProtoBuf label Jun 5, 2020
@erikgrinaker erikgrinaker requested a review from tac0turtle June 5, 2020 16:08
@erikgrinaker erikgrinaker self-assigned this Jun 5, 2020
@auto-comment
Copy link

auto-comment bot commented Jun 5, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳 🥳

@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #4975 into master will decrease coverage by 0.06%.
The diff coverage is 42.85%.

@@            Coverage Diff             @@
##           master    #4975      +/-   ##
==========================================
- Coverage   63.54%   63.48%   -0.07%     
==========================================
  Files         176      175       -1     
  Lines       16498    16498              
==========================================
- Hits        10484    10474      -10     
- Misses       5132     5142      +10     
  Partials      882      882              
Impacted Files Coverage Δ
cmd/tendermint/commands/gen_validator.go 0.00% <0.00%> (ø)
cmd/tendermint/commands/probe_upnp.go 0.00% <0.00%> (ø)
cmd/tendermint/commands/show_validator.go 0.00% <0.00%> (ø)
node/node.go 58.78% <50.00%> (ø)
crypto/sr25519/encoding.go 100.00% <100.00%> (ø)
blockchain/v2/reactor.go 35.35% <0.00%> (-2.55%) ⬇️
p2p/pex/pex_reactor.go 80.42% <0.00%> (-1.59%) ⬇️
blockchain/v0/pool.go 78.02% <0.00%> (-1.28%) ⬇️
statesync/syncer.go 80.23% <0.00%> (+0.79%) ⬆️
blockchain/v0/reactor.go 69.19% <0.00%> (+0.84%) ⬆️
... and 2 more

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from erik/rpc-json to master June 8, 2020 12:04
@erikgrinaker erikgrinaker added the S:automerge Automatically merge PR when requirements pass label Jun 8, 2020
@mergify mergify bot merged commit db8f1b3 into master Jun 8, 2020
@mergify mergify bot deleted the erik/migrate-json branch June 8, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S:automerge Automatically merge PR when requirements pass T:encoding Type: Amino, ProtoBuf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants