abci: minor cleanups in the socket client#3758
Merged
Conversation
tac0turtle
reviewed
Jun 28, 2019
alexanderbez
approved these changes
Jul 2, 2019
AdityaSripal
approved these changes
Jul 2, 2019
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3758 +/- ##
==========================================
+ Coverage 63.89% 64.04% +0.15%
==========================================
Files 217 217
Lines 18136 18136
==========================================
+ Hits 11588 11616 +28
+ Misses 5568 5549 -19
+ Partials 980 971 -9 🚀 New features to boost your workflow:
|
Contributor
Author
I'd say no |
Contributor
The re-ordering change here might be significant enough to warrant a changelog entry |
melekes
added a commit
that referenced
this pull request
Jul 15, 2019
ebuchman
pushed a commit
that referenced
this pull request
Jul 15, 2019
5 tasks
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Sep 30, 2024
…mint#3728) (tendermint#3758) Running a `go get` should consistently build this project as per the README. However, the latest patch release of `btcec/v2` is not a proper Semantic Versioning patch. It removes an error return value from `ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is functionally a no-op, as the underlying function was hardcoded to always return `nil` as error. However, this is still a breaking change (compiler/build error) for all consumers of this function, as they historically expected two return values, but now only get one. Ref: btcsuite/btcd#2211 Ref: tendermint#3531 Ref: tendermint#3536 --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments<hr>This is an automatic backport of pull request tendermint#3728 done by [Mergify](https://mergify.com). --------- Co-authored-by: Valters Jansons <sigv@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #3512
Specifically:
Fixes #3513
Updated all relevant documentation in docsWrote testsUpdated CHANGELOG_PENDING.md