Missing 'b' in python 3 command#3728
Merged
melekes merged 1 commit intotendermint:developfrom Jun 17, 2019
Merged
Conversation
In Python 3 the command outlined in this doc `import codecs; codecs.decode("YWJjZA==", 'base64').decode('ascii')` throws an error:
TypeError: decoding with 'base64' codec failed (TypeError: expected bytes-like object, not str), needs to add 'b' before the encoded string
`import codecs; codecs.decode(b"YWJjZA==", 'base64').decode('ascii')` to make it work
Codecov Report
@@ Coverage Diff @@
## develop #3728 +/- ##
===========================================
+ Coverage 63.93% 63.99% +0.06%
===========================================
Files 241 241
Lines 19856 19970 +114
===========================================
+ Hits 12694 12780 +86
- Misses 6125 6148 +23
- Partials 1037 1042 +5
|
Contributor
|
Thanks for contributing to Tendermint 🚀 🌔 🍸 |
unclezoro
pushed a commit
to unclezoro/tendermint
that referenced
this pull request
Sep 6, 2019
In Python 3 the command outlined in this doc `import codecs; codecs.decode("YWJjZA==", 'base64').decode('ascii')` throws an error:
TypeError: decoding with 'base64' codec failed (TypeError: expected bytes-like object, not str), needs to add 'b' before the encoded string
`import codecs; codecs.decode(b"YWJjZA==", 'base64').decode('ascii')` to make it work
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Sep 30, 2024
…mint#3728) (tendermint#3758) Running a `go get` should consistently build this project as per the README. However, the latest patch release of `btcec/v2` is not a proper Semantic Versioning patch. It removes an error return value from `ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is functionally a no-op, as the underlying function was hardcoded to always return `nil` as error. However, this is still a breaking change (compiler/build error) for all consumers of this function, as they historically expected two return values, but now only get one. Ref: btcsuite/btcd#2211 Ref: tendermint#3531 Ref: tendermint#3536 --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments<hr>This is an automatic backport of pull request tendermint#3728 done by [Mergify](https://mergify.com). --------- Co-authored-by: Valters Jansons <sigv@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
…mint#3728) (#3759) Running a `go get` should consistently build this project as per the README. However, the latest patch release of `btcec/v2` is not a proper Semantic Versioning patch. It removes an error return value from `ecdsa.SignCompact` function (btcsuite/btcd@e5d15fd). This is functionally a no-op, as the underlying function was hardcoded to always return `nil` as error. However, this is still a breaking change (compiler/build error) for all consumers of this function, as they historically expected two return values, but now only get one. Ref: btcsuite/btcd#2211 Ref: tendermint#3531 Ref: tendermint#3536 --- #### PR checklist - [ ] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments<hr>This is an automatic backport of pull request tendermint#3728 done by [Mergify](https://mergify.com). --------- Co-authored-by: Valters Jansons <sigv@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3 the command outlined in this doc
import codecs; codecs.decode("YWJjZA==", 'base64').decode('ascii')throws an error:TypeError: decoding with 'base64' codec failed (TypeError: expected bytes-like object, not str), needs to add 'b' before the encoded string
import codecs; codecs.decode(b"YWJjZA==", 'base64').decode('ascii')to make it work