Conversation
Contributor
ebuchman
commented
Apr 2, 2019
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG_PENDING.md
Bucky/merge master
* Release management using CircleCI * Changelog updated
* lib: remove useless code in group * update change log * Update CHANGELOG_PENDING.md Co-Authored-By: guagualvcha <baifudong@lancai.cn>
* mempool: resCb -> globalCb * reqResCb takes an externalCb * failing test for #3509 * txsMap is sync.Map * update changelog
* Fix for wrong version tag (tag on the release branch instead of master)
Release v0.31.2
* OriginalAddr -> SocketAddr OriginalAddr records the originally dialed address for outbound peers, rather than the peer's self reported address. For inbound peers, it was nil. Here, we rename it to SocketAddr and for inbound peers, set it to the RemoteAddr of the connection. * use SocketAddr Numerous places in the code call peer.NodeInfo().NetAddress(). However, this call to NetAddress() may perform a DNS lookup if the reported NodeInfo.ListenAddr includes a name. Failure of this lookup returns a nil address, which can lead to panics in the code. Instead, call peer.SocketAddr() to return the static address of the connection. * remove nodeInfo.NetAddress() Expose `transport.NetAddress()`, a static result determined when the transport is created. Removing NetAddress() from the nodeInfo prevents accidental DNS lookups. * fixes from review * linter * fixes from review
Release/v0.31.3
liamsi
approved these changes
Apr 2, 2019
Contributor
liamsi
left a comment
There was a problem hiding this comment.
This contains the changes of 0.31.2 and 0.31.3. LGTM 👍
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Sep 30, 2024
…htClientAttackEvidence` types (backport tendermint#3543) (tendermint#3549) Closes tendermint#3528 ### Changes Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence` types. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request tendermint#3543 done by [Mergify](https://mergify.com). --------- Co-authored-by: Alessandro Sforzin <alesforz@gmail.com> Co-authored-by: Alessandro <alessandro@informal.systems>
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Sep 30, 2024
…dermint#3705) Given the discussion in tendermint#3528, we are reverting the changes made by tendermint#3543 in `v0.38.x` (backported with tendermint#3549). Additionally, we are removing the changes made in tendermint#3543 from the CHANGELOG. --- #### PR checklist ~- [ ] Tests written/updated~ ~- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ ~- [] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
…htClientAttackEvidence` types (backport tendermint#3543) (tendermint#3550) Closes tendermint#3528 ### Changes Added missing JSON tags to `DuplicateVoteEvidence` and `LightClientAttackEvidence` types. --- #### PR checklist - [x] Tests written/updated - [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) ~- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec <hr>This is an automatic backport of pull request tendermint#3543 done by [Mergify](https://mergify.com). --------- Co-authored-by: Alessandro Sforzin <alesforz@gmail.com> Co-authored-by: Alessandro <alessandro@informal.systems>
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
…dermint#3704) Given the discussion in tendermint#3528, we are reverting the changes made by tendermint#3543 in `v0.37.x` (backported with tendermint#3550). Additionally, we are removing the changes made in tendermint#3543 from the CHANGELOG. --- #### PR checklist ~- [ ] Tests written/updated~ ~- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ ~- [] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.