Add check for version/version.go TMCoreSemVer#3704
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3704 +/- ##
===========================================
- Coverage 63.51% 63.36% -0.15%
===========================================
Files 218 218
Lines 18239 18239
===========================================
- Hits 11585 11558 -27
- Misses 5693 5708 +15
- Partials 961 973 +12
|
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
…dermint#3704) Given the discussion in tendermint#3528, we are reverting the changes made by tendermint#3543 in `v0.37.x` (backported with tendermint#3550). Additionally, we are removing the changes made in tendermint#3543 from the CHANGELOG. --- #### PR checklist ~- [ ] Tests written/updated~ ~- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)~ ~- [] Updated relevant documentation (`docs/` or `spec/`) and code comments~ - [x] Title follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to prevent #3698 from happening again.
The aim here is to cause the
prepare_buildjob to fail if we're attempting to do a release and theTMCoreSemVervariable in the code doesn't line up with our anticipated next release number.