Skip to content

docs: update RPC docs for /subscribe & /unsubscribe#3705

Merged
melekes merged 3 commits intodevelopfrom
3678-update-rpc-core-events-doc
Jun 4, 2019
Merged

docs: update RPC docs for /subscribe & /unsubscribe#3705
melekes merged 3 commits intodevelopfrom
3678-update-rpc-core-events-doc

Conversation

@melekes
Copy link
Contributor

@melekes melekes commented Jun 3, 2019

Fixes #3678

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@melekes melekes added C:docs Component: Documentation C:rpc Component: JSON RPC, gRPC labels Jun 3, 2019
@melekes melekes requested review from ebuchman and xla as code owners June 3, 2019 02:24
@melekes melekes self-assigned this Jun 3, 2019
@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #3705 into develop will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3705      +/-   ##
===========================================
- Coverage    63.51%   63.44%   -0.08%     
===========================================
  Files          218      218              
  Lines        18239    18239              
===========================================
- Hits         11585    11571      -14     
- Misses        5693     5702       +9     
- Partials       961      966       +5
Impacted Files Coverage Δ
rpc/core/events.go 0% <ø> (ø) ⬆️
libs/events/events.go 93.2% <0%> (-4.86%) ⬇️
privval/signer_service_endpoint.go 85.45% <0%> (-3.64%) ⬇️
privval/socket_listeners.go 93.1% <0%> (-3.45%) ⬇️
privval/signer_validator_endpoint.go 85.55% <0%> (-2.23%) ⬇️
consensus/replay.go 70.2% <0%> (-2.05%) ⬇️
p2p/pex/pex_reactor.go 82.05% <0%> (-1.18%) ⬇️
consensus/reactor.go 71.94% <0%> (-0.24%) ⬇️
consensus/state.go 79.85% <0%> (+0.11%) ⬆️
blockchain/pool.go 81.25% <0%> (+0.98%) ⬆️
... and 1 more

Co-Authored-By: Ethan Buchman <ethan@coinculture.info>
@melekes melekes merged commit 99c9a35 into develop Jun 4, 2019
@melekes melekes deleted the 3678-update-rpc-core-events-doc branch June 4, 2019 01:05
iKapitonau pushed a commit to scrtlabs/tendermint that referenced this pull request Sep 30, 2024
…dermint#3705)

Given the discussion in tendermint#3528, we are reverting the changes made by
tendermint#3543 in `v0.38.x` (backported with tendermint#3549).
Additionally, we are removing the changes made in tendermint#3543 from the
CHANGELOG.

---

#### PR checklist

~- [ ] Tests written/updated~
~- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~
~- [] Updated relevant documentation (`docs/` or `spec/`) and code
comments~
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:docs Component: Documentation C:rpc Component: JSON RPC, gRPC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants