Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2331 +/- ##
==========================================
+ Coverage 60.96% 61.07% +0.1%
==========================================
Files 197 197
Lines 16282 16271 -11
==========================================
+ Hits 9927 9938 +11
+ Misses 5490 5471 -19
+ Partials 865 862 -3
|
melekes
approved these changes
Sep 5, 2018
ebuchman
approved these changes
Sep 5, 2018
| The `DataHash` can provide a nice check on the | ||
| [Data](https://godoc.org/github.com/tendermint/tendermint/types#Data) | ||
| returned in this same block. If you are subscribed to new blocks, via | ||
| tendermint RPC, in order to display or process the new transactions you |
Contributor
There was a problem hiding this comment.
talk about the RPC doesn't belong in the spec. i'll fix in a separate PR
iKapitonau
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Jul 10, 2024
tendermint#2338) This is an automatic backport of pull request tendermint#2331 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Andy Nogueira <me@andynogueira.dev>
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
tendermint#2339) This is an automatic backport of pull request tendermint#2331 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Andy Nogueira <me@andynogueira.dev>
cboh4
pushed a commit
to scrtlabs/tendermint
that referenced
this pull request
Apr 7, 2025
tendermint#2340) This is an automatic backport of pull request tendermint#2331 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Andy Nogueira <me@andynogueira.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from #2143