Skip to content

name drop external contribs in changelog#2340

Merged
ebuchman merged 5 commits intodevelopfrom
bucky/changelog
Sep 5, 2018
Merged

name drop external contribs in changelog#2340
ebuchman merged 5 commits intodevelopfrom
bucky/changelog

Conversation

@ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Sep 5, 2018

Explicitly mention external contributors!

@ebuchman ebuchman requested review from melekes and xla as code owners September 5, 2018 22:14
@ebuchman ebuchman requested a review from zramsay as a code owner September 5, 2018 22:31
@ebuchman ebuchman merged commit bbc30f9 into develop Sep 5, 2018
@codecov-io
Copy link

Codecov Report

Merging #2340 into develop will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2340      +/-   ##
===========================================
+ Coverage    60.94%   61.04%   +0.09%     
===========================================
  Files          197      197              
  Lines        16302    16251      -51     
===========================================
- Hits          9936     9920      -16     
+ Misses        5503     5468      -35     
  Partials       863      863
Impacted Files Coverage Δ
libs/autofile/autofile.go 69.69% <0%> (-6.07%) ⬇️
libs/db/debug_db.go 16% <0%> (-4.64%) ⬇️
consensus/reactor.go 72.48% <0%> (-0.27%) ⬇️
consensus/state.go 77.4% <0%> (+0.23%) ⬆️
p2p/peer.go 59.09% <0%> (+1.13%) ⬆️

chain IDs, you will have a bad time.
- `validators`:
- `pub_key`: The first element specifies the `pub_key` type. 1
chain IDs, you will have a bad time. The ChainID must be less than 50 bytes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

200 bytes (50 symbols 4 bytes each max)

@ebuchman ebuchman mentioned this pull request Sep 7, 2018
@zramsay zramsay deleted the bucky/changelog branch September 8, 2018 17:05
cboh4 pushed a commit to scrtlabs/tendermint that referenced this pull request Apr 7, 2025
tendermint#2340)

This is an automatic backport of pull request tendermint#2331 done by
[Mergify](https://mergify.com).


---


<details>
<summary>Mergify commands and options</summary>

<br />

More conditions and actions can be found in the
[documentation](https://docs.mergify.com/).

You can also trigger Mergify actions by commenting on this pull request:

- `@Mergifyio refresh` will re-evaluate the rules
- `@Mergifyio rebase` will rebase this PR on its base branch
- `@Mergifyio update` will merge the base branch into this PR
- `@Mergifyio backport <destination>` will backport this PR on
`<destination>` branch

Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you
can:

- look at your merge queues
- generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com
</details>

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants