Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2339 +/- ##
===========================================
- Coverage 61% 60.99% -0.02%
===========================================
Files 197 197
Lines 16249 16302 +53
===========================================
+ Hits 9913 9943 +30
- Misses 5476 5494 +18
- Partials 860 865 +5
|
CHANGELOG_PENDING.md
Outdated
| - [rpc] /dial_peers does not try to dial existing peers | ||
| - [config] \#2284 Replace `db_path` with `db_dir` from automatically generated configuration files. | ||
| - [mempool] \#2188 Fix OOM issue from cache map and list getting out of sync | ||
| - [state] #2051 KV store index supports searching by `tx.height` |
CHANGELOG_PENDING.md
Outdated
| - [consensus] \#2203 Implement BFT time | ||
| - Timestamp in block must equal median of timestamps in block's LastCommit | ||
| - [p2p] \#2263 Update secret connection to use a little endian encoded nonce | ||
| - [crypto] \#2205 Rename AminoRoute variables to no longer be prefixed by signature type. |
There was a problem hiding this comment.
This is a Go API thing, the actual routes were unchanged
CHANGELOG_PENDING.md
Outdated
| - Timestamp in block must equal median of timestamps in block's LastCommit | ||
| - [p2p] \#2263 Update secret connection to use a little endian encoded nonce | ||
| - [crypto] \#2205 Rename AminoRoute variables to no longer be prefixed by signature type. | ||
| - [crypto] \#2239 Secp256k1 signature changes (See ADR-014): |
There was a problem hiding this comment.
Can we link to ADR-014 as well?
| IMPROVEMENTS: | ||
| - [docs] Lint documentation with `write-good` and `stop-words`. | ||
| - [scripts] Added json2wal tool, which is supposed to help our users restore | ||
| corrupted WAL files and compose test WAL files (@bradyjoestar) |
There was a problem hiding this comment.
Is suffixing all community contributions with who wrote something we're doing? I don't think I've seen this in changelogs before, but I'm also not opposed.
There was a problem hiding this comment.
Not sure how best to do this but I really would love to give shout outs to open source contributors in the changelog
CHANGELOG_PENDING.md
Outdated
| FEATURES: | ||
| - [types] allow genesis file to have 0 validators ([#2015](https://github.com/tendermint/tendermint/issues/2015)) | ||
| - [libs] allow passing options through when creating instances of leveldb dbs ([#2292](https://github.com/tendermint/tendermint/issues/2292)) | ||
| - [types] Allow genesis file to have 0 validators ([#2015](https://github.com/tendermint/tendermint/issues/2015)) |
There was a problem hiding this comment.
Should we make #2015 follow the same format as everything else? (i.e. be at the front)
|
In the spirit of p2p having its own version (per your ADR), I think it should have its own changelog section instead of being a part of "Protocol". Other than that and my minor comments above, looks good to me |
|
Thanks for the review folks - I addressed everything and added a couple more points we forgot (including max bytes stuff!) |
|
We probably should make a script that takes all regex matches for |
|
I'll make a script to do the above |
tendermint#2339) This is an automatic backport of pull request tendermint#2331 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Updated the changelog to add PR refs and some things I found to be missing.
Need to add a couple more things but have to run for now.
Also changed the "BREAKING" section to have subsections so we can be more clear about what broke and who should care. Here's a direct link: https://github.com/tendermint/tendermint/blob/bucky/changelog/CHANGELOG_PENDING.md
Thoughts?