Skip to content

Release/v0.19.1#1514

Merged
ebuchman merged 46 commits intomasterfrom
release/v0.19.1
Apr 28, 2018
Merged

Release/v0.19.1#1514
ebuchman merged 46 commits intomasterfrom
release/v0.19.1

Conversation

@ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Apr 27, 2018

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Includes:

  • lots of RPC fixes
  • tooling from the devops repo
  • much improved specs re amino and pub keys

melekes and others added 30 commits April 11, 2018 10:08
- Updated Dockerfile and created build-docker target
- Changed localnode docker image to set permissions to more permissive (docker has different user than host system)
- Added sentry node terraform and ansible script
* fix Prove in abci query

* fix Prove in abci query

* fix doc

* fix doc
* [cmd] Turn off strict routability when using testnet cmd

Refs #1454

* use "testnet" instead of "it"
document pre-amino pubkeys/addresses
@ebuchman ebuchman requested a review from melekes as a code owner April 27, 2018 16:28
@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #1514 into master will decrease coverage by 0.15%.
The diff coverage is 69.23%.

@@            Coverage Diff            @@
##           master   #1514      +/-   ##
=========================================
- Coverage   63.85%   63.7%   -0.16%     
=========================================
  Files         102     102              
  Lines        9460    9455       -5     
=========================================
- Hits         6041    6023      -18     
- Misses       2858    2868      +10     
- Partials      561     564       +3
Impacted Files Coverage Δ
config/config.go 81.28% <ø> (-0.11%) ⬇️
p2p/node_info.go 50% <ø> (ø) ⬆️
consensus/replay_file.go 0% <0%> (ø) ⬆️
cmd/tendermint/commands/testnet.go 19.54% <0%> (-0.23%) ⬇️
consensus/wal.go 61.15% <100%> (+1.63%) ⬆️
types/priv_validator/priv_validator.go 71.92% <100%> (ø) ⬆️
config/toml.go 53.19% <100%> (ø) ⬆️
consensus/state.go 77.06% <100%> (-1.09%) ⬇️
node/node.go 64.63% <60%> (ø) ⬆️
... and 4 more

@greg-szabo greg-szabo requested review from greg-szabo and removed request for greg-szabo April 27, 2018 17:10
@ebuchman ebuchman merged commit 26f633e into master Apr 28, 2018
@ebuchman ebuchman deleted the release/v0.19.1 branch April 28, 2018 03:36
cboh4 pushed a commit to scrtlabs/tendermint that referenced this pull request Apr 7, 2025
* node/state:bootstrap state api (tendermint#1057)

* add bootstrap state cmd

* add a missing line

* Initial API impl

* Added error message for missing appHash

* Added changelog, removed cli

* Added PR number

* Unified hex encoding with rest of the code

* Applied PR review comments

* Proper blockstore initialization in case of offline statesync

* Reverted forcing blocksync, not needed for correct operation

* Added changelog and comments

* Removed printfs, added check for empty state store

* Fixed linter

* Apply minor suggestions from code review

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Moved the appHash check up

* Apply minor suggestions from code review

Co-authored-by: Sergio Mena <sergio@informal.systems>

* Apply suggestions from code review

Co-authored-by: Sergio Mena <sergio@informal.systems>

* Fixed linter

* Do not look for VE when starting up after offline statesync

* Extracted  check for offline statesync outside load commit

* Reconstruct seen commit after offline statesync

* Call reconstructSeenCommit from reconstructLastCommit

* Reading offline statesync height only once and passing it as a parameter

* Moved up option initialization to make sure offline statesync is enabled

* Added error to panic message

* Update consensus/state.go

Co-authored-by: Sergio Mena <sergio@informal.systems>

* Apply suggestions from code review

Co-authored-by: Sergio Mena <sergio@informal.systems>

* Adjusted new lines

* Added unit test to test int conversion and fixed linter

* Apply suggestions from code review

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Replaced closing ifs with defer, added errors to error messages

* linter fix

* Adapted bootstrap code to use proper genesis file functions

* Reverted genesis doc changes

* Moved deferred closing before checking for whether the store is empty

* Moved deferred close before error check

---------

Co-authored-by: HuangYi <huang@crypto.com>
Co-authored-by: yihuang <yi.codeplayer@gmail.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>

* Fixed cherry pick conflicts

* Removed go API changes in state store

* Remove breaking go API changes in the blocksync reactor

* Removed breaking changelog and fixed mocks

* [pair programming] Found a more readable way to add the methods needed for the store

* Removed duplicated code from blocksync reactor

* Apply suggestions from code review

Co-authored-by: Sergio Mena <sergio@informal.systems>

* Removed comments

* Removed unused variable from state

---------

Co-authored-by: HuangYi <huang@crypto.com>
Co-authored-by: yihuang <yi.codeplayer@gmail.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants